diff options
| author | torne@chromium.org <torne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-30 19:41:54 +0000 |
|---|---|---|
| committer | torne@chromium.org <torne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-30 19:41:54 +0000 |
| commit | 3822729b80379879b868942aabd8ad741a5c4961 (patch) | |
| tree | 628643e464db5736af040c22df273f9b291b31a4 /base/logging.h | |
| parent | 818bdf2b6bcb61dbe7959e8a735437fc903299c2 (diff) | |
| download | chromium_src-3822729b80379879b868942aabd8ad741a5c4961.zip chromium_src-3822729b80379879b868942aabd8ad741a5c4961.tar.gz chromium_src-3822729b80379879b868942aabd8ad741a5c4961.tar.bz2 | |
Make NOTIMPLEMENTED_POLICY=0 actually work.
Various places in the code use NOTIMPLEMENTED() with << "message" like
the other logging macros; this doesn't work when NOTIMPLEMENTED expands
to a semicolon. Expand it to EAT_STREAM_PARAMETERS instead so any
parameters are simply compiled away in this case.
Review URL: http://codereview.chromium.org/9244006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119711 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/logging.h')
| -rw-r--r-- | base/logging.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/base/logging.h b/base/logging.h index e9faca3..cac520a 100644 --- a/base/logging.h +++ b/base/logging.h @@ -963,7 +963,7 @@ inline std::ostream& operator<<(std::ostream& out, const std::wstring& wstr) { #endif #if NOTIMPLEMENTED_POLICY == 0 -#define NOTIMPLEMENTED() ; +#define NOTIMPLEMENTED() EAT_STREAM_PARAMETERS #elif NOTIMPLEMENTED_POLICY == 1 // TODO, figure out how to generate a warning #define NOTIMPLEMENTED() COMPILE_ASSERT(false, NOT_IMPLEMENTED) |