diff options
author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-16 18:25:37 +0000 |
---|---|---|
committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-16 18:25:37 +0000 |
commit | c21e0e82db0a3e9a60940f7ceea74edb5a1c4122 (patch) | |
tree | 1bf0d8d3ab7e2adab9893158a8be1f8638698e62 /base/logging.h | |
parent | a3cd502bb5891548171a4bb17fe1ce351cd45ba7 (diff) | |
download | chromium_src-c21e0e82db0a3e9a60940f7ceea74edb5a1c4122.zip chromium_src-c21e0e82db0a3e9a60940f7ceea74edb5a1c4122.tar.gz chromium_src-c21e0e82db0a3e9a60940f7ceea74edb5a1c4122.tar.bz2 |
patch
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49982 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/logging.h')
-rw-r--r-- | base/logging.h | 23 |
1 files changed, 12 insertions, 11 deletions
diff --git a/base/logging.h b/base/logging.h index 07a0d0f..f11d3b2 100644 --- a/base/logging.h +++ b/base/logging.h @@ -101,6 +101,18 @@ // There is also the special severity of DFATAL, which logs FATAL in // debug mode, ERROR_REPORT in normal mode. +// XXX better comment -- must be before we use << and in global namespace +// These functions are provided as a convenience for logging, which is where we +// use streams (it is against Google style to use streams in other places). It +// is designed to allow you to emit non-ASCII Unicode strings to the log file, +// which is normally ASCII. It is relatively slow, so try not to use it for +// common cases. Non-ASCII characters will be converted to UTF-8 by these +// operators. +std::ostream& operator<<(std::ostream& out, const wchar_t* wstr); +inline std::ostream& operator<<(std::ostream& out, const std::wstring& wstr) { + return out << wstr.c_str(); +} + namespace logging { // Where to record logging output? A flat file and/or system debug log via @@ -813,17 +825,6 @@ void RawLog(int level, const char* message); } // namespace logging -// These functions are provided as a convenience for logging, which is where we -// use streams (it is against Google style to use streams in other places). It -// is designed to allow you to emit non-ASCII Unicode strings to the log file, -// which is normally ASCII. It is relatively slow, so try not to use it for -// common cases. Non-ASCII characters will be converted to UTF-8 by these -// operators. -std::ostream& operator<<(std::ostream& out, const wchar_t* wstr); -inline std::ostream& operator<<(std::ostream& out, const std::wstring& wstr) { - return out << wstr.c_str(); -} - // The NOTIMPLEMENTED() macro annotates codepaths which have // not been implemented yet. // |