diff options
| author | cmasone@google.com <cmasone@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-17 00:38:12 +0000 |
|---|---|---|
| committer | cmasone@google.com <cmasone@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-17 00:38:12 +0000 |
| commit | 81e0a85082ccf4b14f48ed5229baa2cbd8642ad4 (patch) | |
| tree | 8ba996d8a88dab6c1c9b8a32af78d202e439a254 /base/logging.h | |
| parent | 5c21a2eeaa92326a6a771e27c70b11b1ea52441a (diff) | |
| download | chromium_src-81e0a85082ccf4b14f48ed5229baa2cbd8642ad4.zip chromium_src-81e0a85082ccf4b14f48ed5229baa2cbd8642ad4.tar.gz chromium_src-81e0a85082ccf4b14f48ed5229baa2cbd8642ad4.tar.bz2 | |
Stop eternal loop in DisplayDebugMessageInDialog
if CommandLine was never initialized, CommandLine::ForCurrentProcess() will
DCHECK. That causes DisplayDebugMessageInDialog() to run...which calls
CommandLine::ForCurrentProcess(), which can DCHECK.
Also, Chrome OS doesn't have xmessage, so we don't want to try to pop up a
message using that mechanism.
BUG=None
TEST=Run a binary that doesn't initialize CommandLine (a chrome os unittest binary, for example) and make it CHECK(false). Instead of looping until the stack explodes, it should print messages for the check failures and exit.
Review URL: http://codereview.chromium.org/3151016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56281 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/logging.h')
| -rw-r--r-- | base/logging.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/base/logging.h b/base/logging.h index c63d827..69c67f4 100644 --- a/base/logging.h +++ b/base/logging.h @@ -167,6 +167,11 @@ void SetLogFilterPrefix(const char* filter); void SetLogItems(bool enable_process_id, bool enable_thread_id, bool enable_timestamp, bool enable_tickcount); +// Sets whether or not you'd like to see fatal debug messages popped up in +// a dialog box or not. +// Dialogs are not shown by default. +void SetShowErrorDialogs(bool enable_dialogs); + // Sets the Log Assert Handler that will be used to notify of check failures. // The default handler shows a dialog box and then terminate the process, // however clients can use this function to override with their own handling |