diff options
| author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-02 07:31:09 +0000 |
|---|---|---|
| committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-02 07:31:09 +0000 |
| commit | ddb9b33b95c5fe0224c92292ea53d8bcd5637a54 (patch) | |
| tree | e02b1a90c101e5e18d16bf2adfdd30341a101ce5 /base/logging_unittest.cc | |
| parent | 5310c4cfc1cd1b3d5e7c5a066703b1f2c528d2e9 (diff) | |
| download | chromium_src-ddb9b33b95c5fe0224c92292ea53d8bcd5637a54.zip chromium_src-ddb9b33b95c5fe0224c92292ea53d8bcd5637a54.tar.gz chromium_src-ddb9b33b95c5fe0224c92292ea53d8bcd5637a54.tar.bz2 | |
Make CHECK not print messages in official builds
This cuts down on the number of strings in the executable, as well as
executable code to print them.
On Linux, this saves 208kb on a stripped official build
(chrome executable file went from 64569072 bytes -> 64782064 bytes)
On OS X, this saves 209kb on an official build (Google Chrome Framework went from 51483872 bytes -> 51274984 bytes)
On Windows, this saves 139kb on an official build (chrome.dll went from 28619264 bytes -> 28477440 bytes)
Fix test failure in logging_unittest.cc in official builds.
Add new executable check_example for easy testing of changes to the
CHECK macros.
BUG=101561
TEST=
Review URL: http://codereview.chromium.org/8734021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112649 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/logging_unittest.cc')
| -rw-r--r-- | base/logging_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/base/logging_unittest.cc b/base/logging_unittest.cc index 08d7830..c434129 100644 --- a/base/logging_unittest.cc +++ b/base/logging_unittest.cc @@ -210,7 +210,7 @@ TEST_F(LoggingTest, DcheckStreamsAreLazy) { } TEST_F(LoggingTest, Dcheck) { -#if defined(LOGGING_IS_OFFICIAL_BUILD) +#if LOGGING_IS_OFFICIAL_BUILD // Official build. EXPECT_FALSE(DCHECK_IS_ON()); EXPECT_FALSE(DLOG_IS_ON(DCHECK)); |