diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-26 21:48:00 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-26 21:48:00 +0000 |
commit | a42d4638f0335dbfd14c1c9f6b05a7b09703a78e (patch) | |
tree | 96d7687e21b42cd5b5de4b23b2a1da472572e60c /base/mac/foundation_util.mm | |
parent | 1b5eee12138e3963415453974c824472429c4d80 (diff) | |
download | chromium_src-a42d4638f0335dbfd14c1c9f6b05a7b09703a78e.zip chromium_src-a42d4638f0335dbfd14c1c9f6b05a7b09703a78e.tar.gz chromium_src-a42d4638f0335dbfd14c1c9f6b05a7b09703a78e.tar.bz2 |
Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.
[ Reland of 107042 http://codereview.chromium.org/8368009 ]
I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8341026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/mac/foundation_util.mm')
-rw-r--r-- | base/mac/foundation_util.mm | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/base/mac/foundation_util.mm b/base/mac/foundation_util.mm index 37b001b..8a4ce47 100644 --- a/base/mac/foundation_util.mm +++ b/base/mac/foundation_util.mm @@ -28,7 +28,7 @@ static bool UncachedAmIBundled() { FSRef fsref; OSStatus pbErr; if ((pbErr = GetProcessBundleLocation(&psn, &fsref)) != noErr) { - LOG(ERROR) << "GetProcessBundleLocation failed: error " << pbErr; + DLOG(ERROR) << "GetProcessBundleLocation failed: error " << pbErr; return false; } @@ -36,7 +36,7 @@ static bool UncachedAmIBundled() { OSErr fsErr; if ((fsErr = FSGetCatalogInfo(&fsref, kFSCatInfoNodeFlags, &info, NULL, NULL, NULL)) != noErr) { - LOG(ERROR) << "FSGetCatalogInfo failed: error " << fsErr; + DLOG(ERROR) << "FSGetCatalogInfo failed: error " << fsErr; return false; } @@ -102,7 +102,7 @@ void SetOverrideAppBundle(NSBundle* bundle) { void SetOverrideAppBundlePath(const FilePath& file_path) { NSString* path = base::SysUTF8ToNSString(file_path.value()); NSBundle* bundle = [NSBundle bundleWithPath:path]; - CHECK(bundle) << "Failed to load the bundle at " << file_path.value(); + DCHECK(bundle) << "Failed to load the bundle at " << file_path.value(); SetOverrideAppBundle(bundle); } @@ -146,7 +146,7 @@ bool GetUserDirectory(NSSearchPathDirectory directory, FilePath* result) { FilePath GetUserLibraryPath() { FilePath user_library_path; if (!GetUserDirectory(NSLibraryDirectory, &user_library_path)) { - LOG(WARNING) << "Could not get user library path"; + DLOG(WARNING) << "Could not get user library path"; } return user_library_path; } @@ -212,7 +212,7 @@ CFTypeRef GetValueFromDictionary(CFDictionaryRef dict, CFCopyTypeIDDescription(expected_type)); ScopedCFTypeRef<CFStringRef> actual_type_ref( CFCopyTypeIDDescription(CFGetTypeID(value))); - LOG(WARNING) << "Expected value for key " + DLOG(WARNING) << "Expected value for key " << base::SysCFStringRefToUTF8(key) << " to be " << base::SysCFStringRefToUTF8(expected_type_ref) |