diff options
| author | tedvessenes@gmail.com <tedvessenes@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-19 16:10:55 +0000 |
|---|---|---|
| committer | tedvessenes@gmail.com <tedvessenes@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-19 16:10:55 +0000 |
| commit | eb72b27ac26621b2f1819fa318761a035689482d (patch) | |
| tree | 3df45496be7931641279e35aa691ceb21ef36fa4 /base/mac | |
| parent | cdd47ee7d8b8d2ef57b36cd6e50215320cef7963 (diff) | |
| download | chromium_src-eb72b27ac26621b2f1819fa318761a035689482d.zip chromium_src-eb72b27ac26621b2f1819fa318761a035689482d.tar.gz chromium_src-eb72b27ac26621b2f1819fa318761a035689482d.tar.bz2 | |
Standardize StringToInt{,64} interface.
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114944
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114993 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/mac')
| -rw-r--r-- | base/mac/mac_util.mm | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/base/mac/mac_util.mm b/base/mac/mac_util.mm index 66fbf11..2ba1a30 100644 --- a/base/mac/mac_util.mm +++ b/base/mac/mac_util.mm @@ -14,6 +14,7 @@ #include "base/mac/scoped_cftyperef.h" #include "base/memory/scoped_nsobject.h" #include "base/string_number_conversions.h" +#include "base/string_piece.h" #include "base/sys_string_conversions.h" namespace base { @@ -521,7 +522,9 @@ int DarwinMajorVersionInternal() { int darwin_major_version = 0; char* dot = strchr(uname_info.release, '.'); if (dot) { - if (!base::StringToInt(uname_info.release, dot, &darwin_major_version)) { + if (!base::StringToInt(base::StringPiece(uname_info.release, + dot - uname_info.release), + &darwin_major_version)) { dot = NULL; } } |