summaryrefslogtreecommitdiffstats
path: root/base/mac_util.mm
diff options
context:
space:
mode:
authorlaforge@chromium.org <laforge@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-16 20:22:11 +0000
committerlaforge@chromium.org <laforge@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-16 20:22:11 +0000
commit09b8f82f39b2e3613a4518d9390004522e432063 (patch)
tree5d2f12f8c870fe0b222ae578bd1f8b4a1e1bd360 /base/mac_util.mm
parent44a96738ed0547db89b227399c0b46aa50cbd78e (diff)
downloadchromium_src-09b8f82f39b2e3613a4518d9390004522e432063.zip
chromium_src-09b8f82f39b2e3613a4518d9390004522e432063.tar.gz
chromium_src-09b8f82f39b2e3613a4518d9390004522e432063.tar.bz2
Revert 18512 - Revert 18373 Consider a redirect following user gesture as userinitiated in maintaining
navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 TBR=laforge@chromium.org Review URL: http://codereview.chromium.org/126221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18522 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/mac_util.mm')
0 files changed, 0 insertions, 0 deletions