diff options
| author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-29 07:44:15 +0000 |
|---|---|---|
| committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-29 07:44:15 +0000 |
| commit | 1fb61592c0e6b337475b0cf70fef87879f8071e4 (patch) | |
| tree | 915bac387a7f1597ea03f811c840c59fcf756f7b /base/message_loop.cc | |
| parent | d552b43c982e6804d4833655f0ca360bde6d3492 (diff) | |
| download | chromium_src-1fb61592c0e6b337475b0cf70fef87879f8071e4.zip chromium_src-1fb61592c0e6b337475b0cf70fef87879f8071e4.tar.gz chromium_src-1fb61592c0e6b337475b0cf70fef87879f8071e4.tar.bz2 | |
base: Remove should_leak_tasks_ from MessageLoop
The flag is no longer referenced.
BUG=61131
TEST=base_unittests
Review URL: http://codereview.chromium.org/9903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129586 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/message_loop.cc')
| -rw-r--r-- | base/message_loop.cc | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/base/message_loop.cc b/base/message_loop.cc index 13b0bb6..cc7faa3 100644 --- a/base/message_loop.cc +++ b/base/message_loop.cc @@ -130,7 +130,6 @@ MessageLoop::MessageLoop(Type type) exception_restoration_(false), message_histogram_(NULL), state_(NULL), - should_leak_tasks_(true), #ifdef OS_WIN os_modal_loop_(false), #endif // OS_WIN @@ -509,17 +508,6 @@ void MessageLoop::ReloadWorkQueue() { bool MessageLoop::DeletePendingTasks() { bool did_work = !work_queue_.empty(); - // TODO(darin): Delete all tasks once it is safe to do so. - // Until it is totally safe, just do it when running Valgrind. - // - // See http://crbug.com/61131 - // -#if defined(USE_HEAPCHECKER) - should_leak_tasks_ = false; -#else - if (RunningOnValgrind()) - should_leak_tasks_ = false; -#endif // defined(OS_POSIX) while (!work_queue_.empty()) { PendingTask pending_task = work_queue_.front(); work_queue_.pop(); @@ -541,11 +529,9 @@ bool MessageLoop::DeletePendingTasks() { // code is replicating legacy behavior, and should not be considered // absolutely "correct" behavior. See TODO above about deleting all tasks // when it's safe. - should_leak_tasks_ = false; while (!delayed_work_queue_.empty()) { delayed_work_queue_.pop(); } - should_leak_tasks_ = true; return did_work; } |