summaryrefslogtreecommitdiffstats
path: root/base/message_loop
diff options
context:
space:
mode:
authorsky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-17 00:10:29 +0000
committersky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-17 00:10:29 +0000
commit440e35732993c84fdb45e26f1eb8cb86945248b4 (patch)
tree60551a23078148d37e4ad3f6840cad8763ef5a22 /base/message_loop
parent053a1db400e2f07bd214320c9175b40d56d74eaf (diff)
downloadchromium_src-440e35732993c84fdb45e26f1eb8cb86945248b4.zip
chromium_src-440e35732993c84fdb45e26f1eb8cb86945248b4.tar.gz
chromium_src-440e35732993c84fdb45e26f1eb8cb86945248b4.tar.bz2
Nukes MessageLoop::Dispatcher (2)
There is no point in this typedef now that MessagePumpDispatcher is its own class. BUG=none TEST=none R=darin@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/135563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245387 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/message_loop')
-rw-r--r--base/message_loop/message_loop.h5
-rw-r--r--base/message_loop/message_loop_unittest.cc3
2 files changed, 3 insertions, 5 deletions
diff --git a/base/message_loop/message_loop.h b/base/message_loop/message_loop.h
index 59c6cdc..74eddaf 100644
--- a/base/message_loop/message_loop.h
+++ b/base/message_loop/message_loop.h
@@ -25,9 +25,8 @@
#include "base/time/time.h"
#include "base/tracking_info.h"
+// TODO(sky): these includes should not be necessary. Nuke them.
#if defined(OS_WIN)
-// We need this to declare base::MessagePumpWin::Dispatcher, which we should
-// really just eliminate.
#include "base/message_loop/message_pump_win.h"
#elif defined(OS_IOS)
#include "base/message_loop/message_pump_io_ios.h"
@@ -53,7 +52,6 @@
namespace base {
class HistogramBase;
-class MessagePumpDispatcher;
class MessagePumpObserver;
class RunLoop;
class ThreadTaskRunnerHandle;
@@ -97,7 +95,6 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate {
public:
#if defined(USE_AURA)
- typedef MessagePumpDispatcher Dispatcher;
typedef MessagePumpObserver Observer;
#elif defined(USE_GTK_MESSAGE_PUMP)
typedef MessagePumpGdkObserver Observer;
diff --git a/base/message_loop/message_loop_unittest.cc b/base/message_loop/message_loop_unittest.cc
index 64cf7c8..4a4949d 100644
--- a/base/message_loop/message_loop_unittest.cc
+++ b/base/message_loop/message_loop_unittest.cc
@@ -12,6 +12,7 @@
#include "base/message_loop/message_loop.h"
#include "base/message_loop/message_loop_proxy_impl.h"
#include "base/message_loop/message_loop_test.h"
+#include "base/message_loop/message_pump_dispatcher.h"
#include "base/pending_task.h"
#include "base/posix/eintr_wrapper.h"
#include "base/run_loop.h"
@@ -445,7 +446,7 @@ void PostNTasksThenQuit(int posts_remaining) {
#if defined(OS_WIN)
-class DispatcherImpl : public MessageLoopForUI::Dispatcher {
+class DispatcherImpl : public MessagePumpDispatcher {
public:
DispatcherImpl() : dispatch_count_(0) {}