summaryrefslogtreecommitdiffstats
path: root/base/message_loop
diff options
context:
space:
mode:
authorpcc <pcc@chromium.org>2015-07-17 01:00:27 -0700
committerCommit bot <commit-bot@chromium.org>2015-07-17 08:01:12 +0000
commite5dfea08341c74a24441f9b434dfecdd8d7fe3f6 (patch)
tree0937f388e5c3b27fabcb9682a5305937f04dcf95 /base/message_loop
parent8316e51650ca1632c82460b4247f53c8b8106229 (diff)
downloadchromium_src-e5dfea08341c74a24441f9b434dfecdd8d7fe3f6.zip
chromium_src-e5dfea08341c74a24441f9b434dfecdd8d7fe3f6.tar.gz
chromium_src-e5dfea08341c74a24441f9b434dfecdd8d7fe3f6.tar.bz2
base: Cast completion key, overlapped and this pointers to void* before comparison.
This is a cleanup for -fsanitize=cfi-unrelated-cast; we were previously casting between the unrelated types MessagePumpForIO and IOHandler. BUG=457523,507755 R=cpu@chromium.org,ananta@chromium.org Review URL: https://codereview.chromium.org/1219023007 Cr-Commit-Position: refs/heads/master@{#339228}
Diffstat (limited to 'base/message_loop')
-rw-r--r--base/message_loop/message_pump_win.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/base/message_loop/message_pump_win.cc b/base/message_loop/message_pump_win.cc
index cdbf0c2..292c115 100644
--- a/base/message_loop/message_pump_win.cc
+++ b/base/message_loop/message_pump_win.cc
@@ -614,8 +614,8 @@ bool MessagePumpForIO::GetIOItem(DWORD timeout, IOItem* item) {
}
bool MessagePumpForIO::ProcessInternalIOItem(const IOItem& item) {
- if (this == reinterpret_cast<MessagePumpForIO*>(item.context) &&
- this == reinterpret_cast<MessagePumpForIO*>(item.handler)) {
+ if (reinterpret_cast<void*>(this) == reinterpret_cast<void*>(item.context) &&
+ reinterpret_cast<void*>(this) == reinterpret_cast<void*>(item.handler)) {
// This is our internal completion.
DCHECK(!item.bytes_transfered);
InterlockedExchange(&have_work_, 0);