diff options
author | darin@google.com <darin@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-30 00:22:48 +0000 |
---|---|---|
committer | darin@google.com <darin@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-30 00:22:48 +0000 |
commit | 9bcbf478c173d91958cdabc8a8902619392b7f1f (patch) | |
tree | bad2b3022719370e6eb01a66f94924a1f848a968 /base/message_pump_default.cc | |
parent | 3f9f500b82c82402d9eef92606ebd149762e9f0c (diff) | |
download | chromium_src-9bcbf478c173d91958cdabc8a8902619392b7f1f.zip chromium_src-9bcbf478c173d91958cdabc8a8902619392b7f1f.tar.gz chromium_src-9bcbf478c173d91958cdabc8a8902619392b7f1f.tar.bz2 |
Switch SharedTimerWin over to using PostDelayedTask. I made some tweaks to the
PostDelayedTask implementation to ensure that perf is still good. This
involved recording the intended fire time of PostDelayedTask on the Task object
so that it can be used to properly determine the delay passed to the StartTimer
call. With this change, I am able to service timers (call DoDelayedWork) more
often from within the MessagePump implementations.
R=mbelshe
BUG=1346553
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1578 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/message_pump_default.cc')
-rw-r--r-- | base/message_pump_default.cc | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/base/message_pump_default.cc b/base/message_pump_default.cc index 0460b28..c88f465 100644 --- a/base/message_pump_default.cc +++ b/base/message_pump_default.cc @@ -20,26 +20,18 @@ void MessagePumpDefault::Run(Delegate* delegate) { bool did_work = delegate->DoWork();
if (!keep_running_)
break;
- if (did_work)
- continue;
-
- // TODO(darin): Delayed work will be starved if DoWork continues to return
- // true. We should devise a better strategy.
- //
- // It is tempting to call DoWork followed by DoDelayedWork before checking
- // did_work, but we need to make sure that any tasks that were dispatched
- // prior to a timer actually run before the timer. Getting that right may
- // require some additional changes.
- did_work = delegate->DoDelayedWork(&delayed_work_time_);
+ did_work |= delegate->DoDelayedWork(&delayed_work_time_);
if (!keep_running_)
break;
+
if (did_work)
continue;
did_work = delegate->DoIdleWork();
if (!keep_running_)
break;
+
if (did_work)
continue;
|