diff options
| author | rnk@chromium.org <rnk@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-18 20:42:40 +0000 |
|---|---|---|
| committer | rnk@chromium.org <rnk@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-18 20:42:40 +0000 |
| commit | b957026f43ef9464a8cdd5a240867c807b2281da (patch) | |
| tree | 60a0715b60b838eebbb1f02b4df696e5836f48e1 /base/metrics | |
| parent | 4a2078e05137cddef788d35243f7023dd8d7369e (diff) | |
| download | chromium_src-b957026f43ef9464a8cdd5a240867c807b2281da.zip chromium_src-b957026f43ef9464a8cdd5a240867c807b2281da.tar.gz chromium_src-b957026f43ef9464a8cdd5a240867c807b2281da.tar.bz2 | |
Revert 212378 "Add a HistogramRecorder class and use cases."
This code exhibits addressability bugs under valgrind:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/26205
Please investigate and reland with a clean valgrind trybot run.
> Add a HistogramRecorder class and use cases.
>
> This CL adds a utility class to streamline the task of testing that metrics have been updated as expected. Specifically, the HistogramRecorder class allows a client to obtain the differential value of a given histogram in the interval since the given HistogramRecorder instance was created.
>
> BUG=232414
>
> Review URL: https://chromiumcodereview.appspot.com/18337014
TBR=lpromero@chromium.org
Review URL: https://codereview.chromium.org/19722009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212419 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/metrics')
| -rw-r--r-- | base/metrics/statistics_recorder.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/metrics/statistics_recorder.h b/base/metrics/statistics_recorder.h index 744be01..9a55225 100644 --- a/base/metrics/statistics_recorder.h +++ b/base/metrics/statistics_recorder.h @@ -66,9 +66,9 @@ class BASE_EXPORT StatisticsRecorder { static HistogramBase* FindHistogram(const std::string& name); // GetSnapshot copies some of the pointers to registered histograms into the - // caller supplied vector (Histograms). Only histograms which have query as - // a substring are copied (an empty string will process all registered - // histograms). + // caller supplied vector (Histograms). Only histograms with names matching + // query are returned. The query must be a substring of histogram name for its + // pointer to be copied. static void GetSnapshot(const std::string& query, Histograms* snapshot); private: |