diff options
| author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-20 21:14:21 +0000 |
|---|---|---|
| committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-20 21:14:21 +0000 |
| commit | 6a7dfb3cd638829a04e002ea9bc5b18ed3c9c03f (patch) | |
| tree | 51028572b1a54200e108c954c74d4a8fc98558d6 /base/metrics | |
| parent | b639a833a5f3533509a85bb45c407297b6aa82d2 (diff) | |
| download | chromium_src-6a7dfb3cd638829a04e002ea9bc5b18ed3c9c03f.zip chromium_src-6a7dfb3cd638829a04e002ea9bc5b18ed3c9c03f.tar.gz chromium_src-6a7dfb3cd638829a04e002ea9bc5b18ed3c9c03f.tar.bz2 | |
Revert 242121 "Reland "Add a HistogramRecorder class and use cas..."
As per request from lpromero, reverting since it might be failing a
test - see
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Tests%20%28tsan%29/builds/17153/steps/memory%20test%3A%20base_unittests/logs/stdio
[ RUN ] HistogramTest.BasicTest
[3824:2780:1220/111332:4747750:FATAL:statistics_recorder.cc(270)] Check failed: !histograms_.
TBR=lpromero@chromium.org
> Reland "Add a HistogramRecorder class and use cases."
>
> This CL adds a utility class to streamline the task of testing that metrics have been updated as expected. Specifically, the HistogramRecorder class allows a client to obtain the differential value of a given histogram in the interval since the given HistogramRecorder instance was created.
>
> This reverts commit b957026f43ef9464a8cdd5a240867c807b2281da.
>
> BUG=232414
> TBR=rsleevi, mark, groby, thakis
>
> Review URL: https://codereview.chromium.org/19866004
TBR=lpromero@chromium.org
Review URL: https://codereview.chromium.org/120273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242176 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/metrics')
| -rw-r--r-- | base/metrics/statistics_recorder.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/metrics/statistics_recorder.h b/base/metrics/statistics_recorder.h index 9cf1de7..0716e80 100644 --- a/base/metrics/statistics_recorder.h +++ b/base/metrics/statistics_recorder.h @@ -70,9 +70,9 @@ class BASE_EXPORT StatisticsRecorder { static HistogramBase* FindHistogram(const std::string& name); // GetSnapshot copies some of the pointers to registered histograms into the - // caller supplied vector (Histograms). Only histograms which have |query| as - // a substring are copied (an empty string will process all registered - // histograms). + // caller supplied vector (Histograms). Only histograms with names matching + // query are returned. The query must be a substring of histogram name for its + // pointer to be copied. static void GetSnapshot(const std::string& query, Histograms* snapshot); private: |