summaryrefslogtreecommitdiffstats
path: root/base/metrics
diff options
context:
space:
mode:
authorjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-29 23:06:43 +0000
committerjar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-29 23:06:43 +0000
commitcef8188c3f8680651379f759a72a7bdba4fbe5c7 (patch)
treec2033d110df4ae2d8aba234784d4cd9e655c79c4 /base/metrics
parentfa7ebe0b9d7e66187b5981715cc3905ebd048767 (diff)
downloadchromium_src-cef8188c3f8680651379f759a72a7bdba4fbe5c7.zip
chromium_src-cef8188c3f8680651379f759a72a7bdba4fbe5c7.tar.gz
chromium_src-cef8188c3f8680651379f759a72a7bdba4fbe5c7.tar.bz2
Remove a pair of overly aggressive DCHECKs
Consistency checks (to detect memory corruption) were disabled for non-standard derived forms of histograms (some cache stats were using histograms a bit differently). When I added a virtual function to allow such derived classes to override the checking code, I forgot I had some inline DCHECKs as well. The method for getting the total_count was still DCHECKing the consistency, and there was another consistency assertion made when gathering data for upload to UMA. Both of these DCHECKs, which were not overridden, were removed. They were there to assure my code was working, and to detect memory smashers (or broken DRAM) more quickly... but are too hard to cleanly override (for the one histogram that does not support this facility). BUG=61281 BUG=64268 r=jam Review URL: http://codereview.chromium.org/5365004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67608 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/metrics')
-rw-r--r--base/metrics/histogram.cc1
1 files changed, 0 insertions, 1 deletions
diff --git a/base/metrics/histogram.cc b/base/metrics/histogram.cc
index 2003f25..729e3b9 100644
--- a/base/metrics/histogram.cc
+++ b/base/metrics/histogram.cc
@@ -614,7 +614,6 @@ Count Histogram::SampleSet::TotalCount() const {
++it) {
total += *it;
}
- DCHECK_EQ(total, redundant_count_);
return total;
}