summaryrefslogtreecommitdiffstats
path: root/base/move.h
diff options
context:
space:
mode:
authorsergeygs@chromium.org <sergeygs@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-06 04:22:58 +0000
committersergeygs@chromium.org <sergeygs@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-06 04:22:58 +0000
commitf8bebfb177f7c99e858c56208db69e8f48ed63ad (patch)
tree457e590c9d4693b16149538af8f6eecc3cdea85e /base/move.h
parent358386f8070641cd39a896f72388c3b9b1b56e2c (diff)
downloadchromium_src-f8bebfb177f7c99e858c56208db69e8f48ed63ad.zip
chromium_src-f8bebfb177f7c99e858c56208db69e8f48ed63ad.tar.gz
chromium_src-f8bebfb177f7c99e858c56208db69e8f48ed63ad.tar.bz2
Small fixes around the code
1) Missing member initialization in constructor. 2) More explicit evaluation precedence in an expression. 3) Typos in comments. BUG= Review URL: https://chromiumcodereview.appspot.com/12316136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186355 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/move.h')
-rw-r--r--base/move.h12
1 files changed, 6 insertions, 6 deletions
diff --git a/base/move.h b/base/move.h
index 2bb70ab..d2cd3df 100644
--- a/base/move.h
+++ b/base/move.h
@@ -125,15 +125,15 @@
// Boost.Move makes RValue a fieldless child of the move-only type. RValue&
// is then used in place of RValue in the various operators. The RValue& is
// "created" by doing *reinterpret_cast<RValue*>(this). This has the appeal
-// of never creating a temproary RValue struct even with optimizations
+// of never creating a temporary RValue struct even with optimizations
// disabled. Also, by virtue of inheritance you can treat the RValue
-// reference as if it were the move-only type itself. Unfortuantely,
+// reference as if it were the move-only type itself. Unfortunately,
// using the result of this reinterpret_cast<> is actually undefined behavior
-// due to C++98 5.2.10.7. In certain compilers (eg., NaCl) the optimizer
+// due to C++98 5.2.10.7. In certain compilers (e.g., NaCl) the optimizer
// will generate non-working code.
//
// In optimized builds, both implementations generate the same assembly so we
-// choose the one that adheres to the standard. ☃
+// choose the one that adheres to the standard.
//
//
// COMPARED TO C++11
@@ -144,7 +144,7 @@
// This emulation also has a deficiency where it uses up the single
// user-defined conversion allowed by C++ during initialization. This can
// cause problems in some API edge cases. For instance, in scoped_ptr, it is
-// impossible to make an function "void Foo(scoped_ptr<Parent> p)" accept a
+// impossible to make a function "void Foo(scoped_ptr<Parent> p)" accept a
// value of type scoped_ptr<Child> even if you add a constructor to
// scoped_ptr<> that would make it look like it should work. C++11 does not
// have this deficiency.
@@ -177,7 +177,7 @@
// Since we have no need for writing such APIs yet, our implementation keeps
// RValue private and uses a .Pass() method to do the conversion instead of
// trying to write a version of "std::move()." Writing an API like std::move()
-// would require the RValue structs to be public.
+// would require the RValue struct to be public.
//
//
// CAVEATS