summaryrefslogtreecommitdiffstats
path: root/base/os_compat_android_unittest.cc
diff options
context:
space:
mode:
authorfelipeg@chromium.org <felipeg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-07-16 16:12:16 +0000
committerfelipeg@chromium.org <felipeg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-07-16 16:12:16 +0000
commit4870fe56f847b6f4c1508313a39ae291f6265e9f (patch)
tree9dc19f55f83af11228c8a1790869628dcb31c102 /base/os_compat_android_unittest.cc
parent7ee0fbfcabc6c175b5dd5617b3b1ee10e3e7c827 (diff)
downloadchromium_src-4870fe56f847b6f4c1508313a39ae291f6265e9f.zip
chromium_src-4870fe56f847b6f4c1508313a39ae291f6265e9f.tar.gz
chromium_src-4870fe56f847b6f4c1508313a39ae291f6265e9f.tar.bz2
Upstreaming diffs in os_compat_android.cc
The original change description is: Add mkdtemp() implementation. The Android C library doesn't expose mkdtemp() through the NDK (even though it implements it internally starting with ICS). To avoid any problem in the future and keep everything strictly compliant, provide our own implementation of the function. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10696114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146813 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/os_compat_android_unittest.cc')
-rw-r--r--base/os_compat_android_unittest.cc41
1 files changed, 41 insertions, 0 deletions
diff --git a/base/os_compat_android_unittest.cc b/base/os_compat_android_unittest.cc
new file mode 100644
index 0000000..c749b6a2
--- /dev/null
+++ b/base/os_compat_android_unittest.cc
@@ -0,0 +1,41 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/os_compat_android.h"
+
+#include "base/file_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace base {
+
+typedef testing::Test OsCompatAndroidTest;
+
+// Keep this Unittest DISABLED_ , because it actually creates a directory in the
+// device and it may be source of flakyness. For any changes in the mkdtemp
+// function, you should run this unittest in your local machine to check if it
+// passes.
+TEST_F(OsCompatAndroidTest, DISABLED_TestMkdTemp) {
+ FilePath tmp_dir;
+ EXPECT_TRUE(file_util::GetTempDir(&tmp_dir));
+
+ // Not six XXXXXX at the suffix of the path.
+ FilePath sub_dir = tmp_dir.Append("XX");
+ std::string sub_dir_string = sub_dir.value();
+ // this should be OK since mkdtemp just replaces characters in place
+ char* buffer = const_cast<char*>(sub_dir_string.c_str());
+ EXPECT_EQ(NULL, mkdtemp(buffer));
+
+ // Directory does not exist
+ char invalid_path2[] = "doesntoexist/foobarXXXXXX";
+ EXPECT_EQ(NULL, mkdtemp(invalid_path2));
+
+ // Successfully create a tmp dir.
+ FilePath sub_dir2 = tmp_dir.Append("XXXXXX");
+ std::string sub_dir2_string = sub_dir2.value();
+ // this should be OK since mkdtemp just replaces characters in place
+ char* buffer2 = const_cast<char*>(sub_dir2_string.c_str());
+ EXPECT_TRUE(mkdtemp(buffer2) != NULL);
+}
+
+} // namespace base