diff options
author | glen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-09 20:47:18 +0000 |
---|---|---|
committer | glen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-09 20:47:18 +0000 |
commit | 20448a1990372714ec98cbfdb2a051c40bd30316 (patch) | |
tree | 5131d1e9fc3e17a2cae73a816a5daf131187e3df /base/path_service.h | |
parent | a81e5f4317b551631f7d516594a6a12e11373535 (diff) | |
download | chromium_src-20448a1990372714ec98cbfdb2a051c40bd30316.zip chromium_src-20448a1990372714ec98cbfdb2a051c40bd30316.tar.gz chromium_src-20448a1990372714ec98cbfdb2a051c40bd30316.tar.bz2 |
Revert 55450 - Fix CheckFalseTest.CheckFails on Linux after my change to ui_test.
This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.
Added a comment that PathService::Override should not be called
by production code.
TEST=ui_tests in Release mode
BUG=49838
Review URL: http://codereview.chromium.org/2805100
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3107001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55468 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/path_service.h')
-rw-r--r-- | base/path_service.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/base/path_service.h b/base/path_service.h index 4d99cdc..2b59247 100644 --- a/base/path_service.h +++ b/base/path_service.h @@ -45,6 +45,9 @@ class PathService { // over the lifetime of the app, so this method should be used with caution. static bool Override(int key, const FilePath& path); + // Return whether a path was overridden. + static bool IsOverridden(int key); + // To extend the set of supported keys, you can register a path provider, // which is just a function mirroring PathService::Get. The ProviderFunc // returns false if it cannot provide a non-empty path for the given key. @@ -62,7 +65,6 @@ class PathService { int key_end); private: static bool GetFromCache(int key, FilePath* path); - static bool GetFromOverrides(int key, FilePath* path); static void AddToCache(int key, const FilePath& path); }; |