diff options
| author | vandebo@chromium.org <vandebo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-19 21:51:39 +0000 |
|---|---|---|
| committer | vandebo@chromium.org <vandebo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-19 21:51:39 +0000 |
| commit | 5fde9812dbd02a294af8eb5966548fae2884bd98 (patch) | |
| tree | abd856e85baf1e33f2a4fbe20226574c91f0b26b /base/platform_file.h | |
| parent | 72b1783f335eb17b717f108fd8961a6878d5ef94 (diff) | |
| download | chromium_src-5fde9812dbd02a294af8eb5966548fae2884bd98.zip chromium_src-5fde9812dbd02a294af8eb5966548fae2884bd98.tar.gz chromium_src-5fde9812dbd02a294af8eb5966548fae2884bd98.tar.bz2 | |
Fix the case where the browser livelocks if we cannot open a file.
If one tries to upload a file that one doesn't have read access to,
the browser livelocks. It tries to read from the file, gets nothing
but spins forever because it knows that it hasn't finished reading.
To address this, firstly we add a check at stat() time to make sure
that we can read the file. However, this doesn't take care of the case
where the access() call was incorrect, or the permissions have changed
under us. In this case, we replace the missing file with NULs.
BUG=30850
Review URL: http://codereview.chromium.org/541022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42152 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/platform_file.h')
| -rw-r--r-- | base/platform_file.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/base/platform_file.h b/base/platform_file.h index 0dbf4e4..46ff0cc 100644 --- a/base/platform_file.h +++ b/base/platform_file.h @@ -6,6 +6,8 @@ #define BASE_PLATFORM_FILE_H_ #include "build/build_config.h" +#include "base/basictypes.h" + #if defined(OS_WIN) #include <windows.h> #endif @@ -53,6 +55,10 @@ PlatformFile CreatePlatformFile(const std::wstring& name, // Closes a file handle bool ClosePlatformFile(PlatformFile file); +// Get the length of an underlying file. Returns false on error. Otherwise +// *size is set to the length of the file, in bytes. +bool GetPlatformFileSize(PlatformFile file, uint64* size); + } // namespace base #endif // BASE_PLATFORM_FILE_H_ |