Send pref change notifications when changing the default value for a pref.

TBR=ben@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/12541008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186662 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 25 insertions, 8 deletions

diff --git a/base/prefs/default_pref_store.cc b/base/prefs/default_pref_store.cc
index 3df9ad9..babb4d5 100644
--- a/base/prefs/default_pref_store.cc
+++ b/base/prefs/default_pref_store.cc
@@ -9,20 +9,37 @@ using base::Value;
 
 DefaultPrefStore::DefaultPrefStore() {}
 
-bool DefaultPrefStore::GetValue(
-    const std::string& key,
-    const base::Value** result) const {
+bool DefaultPrefStore::GetValue(const std::string& key,
+                                const Value** result) const {
   return prefs_.GetValue(key, result);
 }
 
-void DefaultPrefStore::SetDefaultValue(const std::string& key, Value* value) {
+void DefaultPrefStore::AddObserver(PrefStore::Observer* observer) {
+  observers_.AddObserver(observer);
+}
+
+void DefaultPrefStore::RemoveObserver(PrefStore::Observer* observer) {
+  observers_.RemoveObserver(observer);
+}
+
+size_t DefaultPrefStore::NumberOfObservers() const {
+  return observers_.size();
+}
+
+void DefaultPrefStore::SetDefaultValue(const std::string& key,
+                                       scoped_ptr<Value> value) {
   DCHECK(!GetValue(key, NULL));
-  prefs_.SetValue(key, value);
+  prefs_.SetValue(key, value.release());
 }
 
-void DefaultPrefStore::RemoveDefaultValue(const std::string& key) {
-  DCHECK(GetValue(key, NULL));
-  prefs_.RemoveValue(key);
+void DefaultPrefStore::ReplaceDefaultValue(const std::string& key,
+                                           scoped_ptr<Value> value) {
+  const Value* old_value = NULL;
+  GetValue(key, &old_value);
+  bool notify = !old_value->Equals(value.get());
+  prefs_.SetValue(key, value.release());
+  if (notify)
+    FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
 }
 
 DefaultPrefStore::const_iterator DefaultPrefStore::begin() const {