diff options
| author | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-20 11:25:12 +0000 |
|---|---|---|
| committer | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-20 11:25:12 +0000 |
| commit | 6d75f1ef04b673ff837d54afb0198ce1ee0115df (patch) | |
| tree | e901e51403802359bedfd247090dddf87e0e1a63 /base/prefs/pref_notifier_impl_unittest.cc | |
| parent | a4db77720743aff23aff283379a4ac98608cb678 (diff) | |
| download | chromium_src-6d75f1ef04b673ff837d54afb0198ce1ee0115df.zip chromium_src-6d75f1ef04b673ff837d54afb0198ce1ee0115df.tar.gz chromium_src-6d75f1ef04b673ff837d54afb0198ce1ee0115df.tar.bz2 | |
Revert 271416 "Store a stacktrace of PrefService destruction in ..."
Speculative revert, suspecting this CL resulted in timeouts of the
following tests on ChromiumOS:
ExtensionUpdaterTest.TestGalleryRequestsWithNonOrganicBrand
ExtensionUpdaterTest.TestGalleryRequestsWithOrganicBrand
Test run time went from ~2s per test to >40s per test (and
higher) causing timeouts.
> Store a stacktrace of PrefService destruction in PrefChangeRegistrar
>
> Store a stacktrace of PrefService destruction in PrefChangeRegistrar to debug a
> race condition: ~PrefChangeRegistrar causes a crash. The current hypothesis is
> that this is caused because the PrefChangeRegistrar is registered to a Profile
> that is already destroyed. This code stores stacktrace when the Profile's
> PrefService is destroyed to see whether this is correct.
>
> BUG=373435
>
> Review URL: https://codereview.chromium.org/290083006
TBR=battre@chromium.org
Review URL: https://codereview.chromium.org/289373006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271622 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/prefs/pref_notifier_impl_unittest.cc')
| -rw-r--r-- | base/prefs/pref_notifier_impl_unittest.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/base/prefs/pref_notifier_impl_unittest.cc b/base/prefs/pref_notifier_impl_unittest.cc index 1eae56b..8482c02 100644 --- a/base/prefs/pref_notifier_impl_unittest.cc +++ b/base/prefs/pref_notifier_impl_unittest.cc @@ -80,9 +80,6 @@ class PrefObserverMock : public PrefObserver { virtual ~PrefObserverMock() {} MOCK_METHOD2(OnPreferenceChanged, void(PrefService*, const std::string&)); - - // TODO(battre) Remove function. See crbug.com/373435. - MOCK_METHOD1(SetPrefServiceDestructionTrace, void(const std::string&)); }; // Test fixture class. |