diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-18 02:23:16 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-18 02:23:16 +0000 |
| commit | 57113eacd955181e1267f3f20b889bc6fbfd07f2 (patch) | |
| tree | 6577b6941409f45cb0215c92f37c4497e62fa87a /base/process.h | |
| parent | e6dbc8c4542c677d6d1a01806535274c1865f69f (diff) | |
| download | chromium_src-57113eacd955181e1267f3f20b889bc6fbfd07f2.zip chromium_src-57113eacd955181e1267f3f20b889bc6fbfd07f2.tar.gz chromium_src-57113eacd955181e1267f3f20b889bc6fbfd07f2.tar.bz2 | |
Linux: Enable metrics_service_uitest.cc. Take 2.
Relands r18641, original code review: http://codereview.chromium.org/125268
Expect a crash on Windows.
The old method of crashing was flawed on posix (KillProcess just does a SIGTERM). On Windows though, it would terminate the process with the desired exit code, in order to make DidProcessCrash() return true. This process termination does not dump crash information though, since it just forcibly terminates the process, like a SIGKILL on posix. When I switched it to navigate to about:crash though, it actually crashes, and dumps crash information, which the UITest in windows (but not linux/mac) detects. Therefore, until those platforms can detect, we just use #if defined(OS_WIN) around the expected_crashes = 1.
Review URL: http://codereview.chromium.org/131007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18680 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process.h')
| -rw-r--r-- | base/process.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/base/process.h b/base/process.h index 312f84c..459ad58 100644 --- a/base/process.h +++ b/base/process.h @@ -6,6 +6,7 @@ #define BASE_PROCESS_H_ #include "base/basictypes.h" +#include "build/build_config.h" #include <sys/types.h> #ifdef OS_WIN |