diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-12 00:39:15 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-12 00:39:15 +0000 |
| commit | c002879632b0e46b11e91e5595a83652f7cafd3c (patch) | |
| tree | 87477d9e6b972292fbb98484ec3721f084ab41c4 /base/process_util.h | |
| parent | 62ed4d36e4357deaf863711bdfd1f00b367c426a (diff) | |
| download | chromium_src-c002879632b0e46b11e91e5595a83652f7cafd3c.zip chromium_src-c002879632b0e46b11e91e5595a83652f7cafd3c.tar.gz chromium_src-c002879632b0e46b11e91e5595a83652f7cafd3c.tar.bz2 | |
Mac: Other approach for IPCing child task_ts.
Also move mach_ipc_mac to base, where it's now used.
Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , but uses a named connection instead. Do the IPC right after fork-time, so that the sandbox is not yet in effect.
See the codereview comments for a benchmark that proves that this shouldn't be expensive, and for pros and cons for using a named connection vs temporarily switching out the bootstrap port.
Works for worker processes too and seems more reliable in general.
Measured perf impact in http://src.chromium.org/viewvc/chrome?view=rev&revision=35888 , it's negligible.
BUG=13156
TEST=(requires that one enables the task manager in browser.cc)
1.) Open one tab that plays a youtube video
2.) Open a second and visit http://www.whatwg.org/demos/workers/primes/page.html
3.) Install e.g. the gmail checker extension
4.) Open the task manager
It should report metrics for
* one browser process
* two renderer processes
* one plugin process
* one worker process
* one extension process
Check that %cpu etc more or less match what Activity Monitor displays if you filter for "Chromium".
Also choose "Open all bookmarks" on the bookmarks bar with the task manager open and check that metrics for all tabs appear immediately.
Review URL: http://codereview.chromium.org/549002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35977 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process_util.h')
| -rw-r--r-- | base/process_util.h | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/base/process_util.h b/base/process_util.h index cec37bd..eb21188 100644 --- a/base/process_util.h +++ b/base/process_util.h @@ -17,6 +17,7 @@ // kinfo_proc is defined in <sys/sysctl.h>, but this forward declaration // is sufficient for the vector<kinfo_proc> below. struct kinfo_proc; +#include <mach/mach.h> #elif defined(OS_POSIX) #include <dirent.h> #include <limits.h> @@ -155,13 +156,25 @@ bool LaunchApp(const std::vector<std::string>& argv, const file_handle_mapping_vector& fds_to_remap, bool wait, ProcessHandle* process_handle); -// Similar to above, but also (un)set environment variables in child process +// Similar to the above, but also (un)set environment variables in child process // through |environ|. typedef std::vector<std::pair<std::string, std::string> > environment_vector; bool LaunchApp(const std::vector<std::string>& argv, const environment_vector& environ, const file_handle_mapping_vector& fds_to_remap, bool wait, ProcessHandle* process_handle); + +#if defined(OS_MACOSX) +// Similar to the above, but also returns the new process's task_t if +// |task_handle| is not NULL. If |task_handle| is not NULL, the caller is +// responsible for calling |mach_port_deallocate()| on the returned handle. +bool LaunchAppAndGetTask(const std::vector<std::string>& argv, + const environment_vector& environ, + const file_handle_mapping_vector& fds_to_remap, + bool wait, + task_t* task_handle, + ProcessHandle* process_handle); +#endif // defined(OS_MACOSX) #endif // defined(OS_POSIX) // Executes the application specified by cl. This function delegates to one |