diff options
| author | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-03 21:27:36 +0000 |
|---|---|---|
| committer | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-03 21:27:36 +0000 |
| commit | e9a8c19f1f6af2cbfdde08a2884175e521bcef55 (patch) | |
| tree | d7c807c51b0384379dba1be98c05f8def8804701 /base/process_util.h | |
| parent | f26bda5f49ce07483f8033b75c9748a2eaa8ba79 (diff) | |
| download | chromium_src-e9a8c19f1f6af2cbfdde08a2884175e521bcef55.zip chromium_src-e9a8c19f1f6af2cbfdde08a2884175e521bcef55.tar.gz chromium_src-e9a8c19f1f6af2cbfdde08a2884175e521bcef55.tar.bz2 | |
When forking, restore the default exception handler port.
The browser process launches children with fork && exec. On the Mac, this
results in a child that has its exception ports set the same as the parent.
When Breakpad is enabled, this means that a child such as a renderer process
begins its life with its exception port pointing to a Breakpad instance
running inside the browser. This is not intended. Even if the child installs
its own Breakpad handler (which a renderer would), the previous handler would
be pointing to the instance inside the browser, and if the child's Breakpad
is misconfigured to pass exceptions to the previous handler it will wind up
being passed back to the parent. The misconfiguration was corrected in r25311.
This change restores the default exception handler port, which should be
Apple Crash Reporter/ReportCrash, in the child process immediately after it
it has been forked.
BUG=20371
TEST=None, because r25311 fixed the visible aspect of this bug
Review URL: http://codereview.chromium.org/200007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25371 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process_util.h')
| -rw-r--r-- | base/process_util.h | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/base/process_util.h b/base/process_util.h index 91cca61..17ee3c7 100644 --- a/base/process_util.h +++ b/base/process_util.h @@ -414,6 +414,17 @@ void EnableTerminationOnHeapCorruption(); // the current process's scheduling priority to a high priority. void RaiseProcessToHighPriority(); +#if defined(OS_MACOSX) +// Restore the default exception handler, setting it to Apple Crash Reporter +// (ReportCrash). When forking and execing a new process, the child will +// inherit the parent's exception ports, which may be set to the Breakpad +// instance running inside the parent. The parent's Breakpad instance should +// not handle the child's exceptions. Calling RestoreDefaultExceptionHandler +// in the child after forking will restore the standard exception handler. +// See http://crbug.com/20371/ for more details. +void RestoreDefaultExceptionHandler(); +#endif + } // namespace base #endif // BASE_PROCESS_UTIL_H_ |