diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-21 08:09:30 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-21 08:09:30 +0000 |
| commit | 1912cfef3207b30c2691a3f71c524a69ac969b19 (patch) | |
| tree | e13101b5a3c721dfd3a00179a49e43b454dcd5d5 /base/process_util.h | |
| parent | 37f876a54ffb14d1630b1c0ebdbeda82ed150816 (diff) | |
| download | chromium_src-1912cfef3207b30c2691a3f71c524a69ac969b19.zip chromium_src-1912cfef3207b30c2691a3f71c524a69ac969b19.tar.gz chromium_src-1912cfef3207b30c2691a3f71c524a69ac969b19.tar.bz2 | |
More solid detection of browser process in chrome_process_util_linux.cc:
- use GetAppOutput instead of popen
- make unexpected conditions fatal (otherwise the tests using this code
would mistakenly assume that there is no running browser process)
Also add a constant for SingletonSocket.
Make necessary adjustments to GetAppOutput - ignore stderr (because fuser
prints the file name to stderr and having stderr in |output| would
require more parsing).
Review URL: http://codereview.chromium.org/77031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14091 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process_util.h')
| -rw-r--r-- | base/process_util.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/base/process_util.h b/base/process_util.h index 367c772..20cdd5e 100644 --- a/base/process_util.h +++ b/base/process_util.h @@ -126,9 +126,10 @@ bool LaunchApp(const CommandLine& cl, #if defined(OS_POSIX) // Execute the application specified by |cl| and wait for it to exit. Store -// the output (stdout and stderr) in |output|. Returns true on success -// (application launched and exited cleanly, with exit code indicating success). -// |output| is modified only when the function finished successfully. +// the output (stdout) in |output|. Redirects stderr to /dev/null. Returns true +// on success (application launched and exited cleanly, with exit code +// indicating success). |output| is modified only when the function finished +// successfully. bool GetAppOutput(const CommandLine& cl, std::string* output); #endif // defined(OS_POSIX) |