diff options
| author | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-10 18:26:33 +0000 |
|---|---|---|
| committer | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-10 18:26:33 +0000 |
| commit | 96878a218c1435911233ab9b5b42efe8d0a88db8 (patch) | |
| tree | 6ccf804b44ecfb816965a70ae5ce2f924d27fb48 /base/process_util.h | |
| parent | 28877041246461af71a33e53fd8b5438843ee12d (diff) | |
| download | chromium_src-96878a218c1435911233ab9b5b42efe8d0a88db8.zip chromium_src-96878a218c1435911233ab9b5b42efe8d0a88db8.tar.gz chromium_src-96878a218c1435911233ab9b5b42efe8d0a88db8.tar.bz2 | |
Changed the position of the output->swap() call. This way, even if the command encounters an error, we still record the output. This is important for the case when stderr has been redirected to stdout, and we'd like to see stdout even when the exit code is non-zero.
Patch contributed by Michael Williamson.
Review URL: http://codereview.chromium.org/2665004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49423 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process_util.h')
| -rw-r--r-- | base/process_util.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/base/process_util.h b/base/process_util.h index b8bcfd4..d6aed0d 100644 --- a/base/process_util.h +++ b/base/process_util.h @@ -232,8 +232,7 @@ bool LaunchApp(const CommandLine& cl, // Executes the application specified by |cl| and wait for it to exit. Stores // the output (stdout) in |output|. Redirects stderr to /dev/null. Returns true // on success (application launched and exited cleanly, with exit code -// indicating success). |output| is modified only when the function finished -// successfully. +// indicating success). bool GetAppOutput(const CommandLine& cl, std::string* output); #if defined(OS_POSIX) |