diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-01 16:27:28 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-01 16:27:28 +0000 |
| commit | 71f1fc95107fb420699ebbabc15ff4b79ff9c305 (patch) | |
| tree | 94e105849cf3375a2f4ea1a20f48b76625c050aa /base/process_util_mac.mm | |
| parent | d3bf9da2e8e0162dd4429aaaf7b6a0bbeef93472 (diff) | |
| download | chromium_src-71f1fc95107fb420699ebbabc15ff4b79ff9c305.zip chromium_src-71f1fc95107fb420699ebbabc15ff4b79ff9c305.tar.gz chromium_src-71f1fc95107fb420699ebbabc15ff4b79ff9c305.tar.bz2 | |
Fixes possible crash in showing menus. This is less likely now that
main menu is using the bookmark menu, but still worth trying to
fix. We run a nested message loop when showing a menu. When a click
occurs outside the menu gtk closes the menu and we exit the nested
message loop. The problem is that click is dispatched from the nested
message loop, meaning it's possible to attempt to spawn another menu
or do other things from the nested message loop. To fix it I'm
manually closing the popup and not dispatching the event.
BUG=40492
TEST=see bug, but in general make sure chrome specific menus (time,
network ...) continue to work.
Review URL: http://codereview.chromium.org/2861037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51372 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process_util_mac.mm')
0 files changed, 0 insertions, 0 deletions