diff options
| author | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-13 18:27:40 +0000 |
|---|---|---|
| committer | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-13 18:27:40 +0000 |
| commit | 57b765671983005059e8be4523872796b9505428 (patch) | |
| tree | c84b82b586cae2b39ef784f1ee1d58c1431bb140 /base/process_util_posix.cc | |
| parent | fd8d08436730ef67591de7665da88e995159b773 (diff) | |
| download | chromium_src-57b765671983005059e8be4523872796b9505428.zip chromium_src-57b765671983005059e8be4523872796b9505428.tar.gz chromium_src-57b765671983005059e8be4523872796b9505428.tar.bz2 | |
Eliminate all uses of strerror() in code that uses src/base. strerror() is inherently unsafe in multi-threaded apps because it stores the string in a global buffer. It should never be used. If you want to log an error, use PLOG and friends, or if that's too high-level then use safe_strerror().
TEST=built on Linux in 32-bit and 64-bit mode; ran base_unittests in each case; ran Chromium itself in each case; try servers
BUG=none
Review URL: http://codereview.chromium.org/261055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28850 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process_util_posix.cc')
| -rw-r--r-- | base/process_util_posix.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/base/process_util_posix.cc b/base/process_util_posix.cc index 235456b..61ecb7e 100644 --- a/base/process_util_posix.cc +++ b/base/process_util_posix.cc @@ -274,8 +274,7 @@ bool LaunchApp(const std::vector<std::string>& argv, argv_cstr[i] = const_cast<char*>(argv[i].c_str()); argv_cstr[argv.size()] = NULL; execvp(argv_cstr[0], argv_cstr.get()); - LOG(ERROR) << "LaunchApp: execvp(" << argv_cstr[0] << ") failed: " - << strerror(errno); + PLOG(ERROR) << "LaunchApp: execvp(" << argv_cstr[0] << ") failed"; _exit(127); } else { // Parent process @@ -333,7 +332,7 @@ bool DidProcessCrash(bool* child_exited, ProcessHandle handle) { int status; const int result = HANDLE_EINTR(waitpid(handle, &status, WNOHANG)); if (result == -1) { - LOG(ERROR) << "waitpid(" << handle << "): " << strerror(errno); + PLOG(ERROR) << "waitpid(" << handle << ")"; if (child_exited) *child_exited = false; return false; |