diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-15 16:47:02 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-15 16:47:02 +0000 |
| commit | e599218171e942749da5c8b3931b091655c1b74c (patch) | |
| tree | 703ee7f0427e0bafabb1402e678c40c31acec38e /base/process_util_posix.cc | |
| parent | 24ea7da0968595f5365a537fba548e9163f1f371 (diff) | |
| download | chromium_src-e599218171e942749da5c8b3931b091655c1b74c.zip chromium_src-e599218171e942749da5c8b3931b091655c1b74c.tar.gz chromium_src-e599218171e942749da5c8b3931b091655c1b74c.tar.bz2 | |
Change base::LaunchProcess API slightly
Rather than passing the out param process handle via the options,
take it as a function argument. This simplifies many callers.
BUG=88990
Review URL: http://codereview.chromium.org/7377012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92701 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process_util_posix.cc')
| -rw-r--r-- | base/process_util_posix.cc | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/base/process_util_posix.cc b/base/process_util_posix.cc index 0e116de..0fc8c0e 100644 --- a/base/process_util_posix.cc +++ b/base/process_util_posix.cc @@ -528,7 +528,8 @@ char** AlterEnvironment(const environment_vector& changes, } bool LaunchProcess(const std::vector<std::string>& argv, - const LaunchOptions& options) { + const LaunchOptions& options, + ProcessHandle* process_handle) { pid_t pid; InjectiveMultimap fd_shuffle1, fd_shuffle2; if (options.fds_to_remap) { @@ -631,16 +632,17 @@ bool LaunchProcess(const std::vector<std::string>& argv, DPCHECK(ret > 0); } - if (options.process_handle) - *options.process_handle = pid; + if (process_handle) + *process_handle = pid; } return true; } bool LaunchProcess(const CommandLine& cmdline, - const LaunchOptions& options) { - return LaunchProcess(cmdline.argv(), options); + const LaunchOptions& options, + ProcessHandle* process_handle) { + return LaunchProcess(cmdline.argv(), options, process_handle); } ProcessMetrics::~ProcessMetrics() { } |