Make DidProcessCrash a bit more solid and accurate on Windows

I hit the NOTREACHED() inside it while debugging an unrelated problem.

Also, now there is one less special case in this function's contract.

TEST=none
BUG=38048

Review URL: http://codereview.chromium.org/1315009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43706 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 18 insertions, 0 deletions

diff --git a/base/process_util_unittest.cc b/base/process_util_unittest.cc
index 296aaa9..b4d9b9f 100644
--- a/base/process_util_unittest.cc
+++ b/base/process_util_unittest.cc
@@ -78,6 +78,24 @@ TEST_F(ProcessUtilTest, KillSlowChild) {
   base::CloseProcessHandle(handle);
 }
 
+TEST_F(ProcessUtilTest, DidProcessCrash) {
+  remove("SlowChildProcess.die");
+  ProcessHandle handle = this->SpawnChild(L"SlowChildProcess");
+  ASSERT_NE(base::kNullProcessHandle, handle);
+
+  bool child_exited = true;
+  EXPECT_FALSE(base::DidProcessCrash(&child_exited, handle));
+  EXPECT_FALSE(child_exited);
+
+  FILE *fp = fopen("SlowChildProcess.die", "w");
+  fclose(fp);
+  EXPECT_TRUE(base::WaitForSingleProcess(handle, 5000));
+
+  EXPECT_FALSE(base::DidProcessCrash(&child_exited, handle));
+
+  base::CloseProcessHandle(handle);
+}
+
 // Ensure that the priority of a process is restored correctly after
 // backgrounding and restoring.
 // Note: a platform may not be willing or able to lower the priority of