diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-13 18:57:46 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-13 18:57:46 +0000 |
| commit | ca020961d05b2c38dcc94c0e10a4ab41dbeac900 (patch) | |
| tree | aeab55264e5064fd3dea7ea029965520ec42d0ba /base/process_util_unittest.cc | |
| parent | e33920797943e123825f343b07d2d40a71067af0 (diff) | |
| download | chromium_src-ca020961d05b2c38dcc94c0e10a4ab41dbeac900.zip chromium_src-ca020961d05b2c38dcc94c0e10a4ab41dbeac900.tar.gz chromium_src-ca020961d05b2c38dcc94c0e10a4ab41dbeac900.tar.bz2 | |
Fix TODOs in base/ :
- switch to FilePath inside CopyDirectory
- be less racy in ProcessUtilTest.KillSlowChild
Review URL: http://codereview.chromium.org/17013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7948 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/process_util_unittest.cc')
| -rw-r--r-- | base/process_util_unittest.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/base/process_util_unittest.cc b/base/process_util_unittest.cc index 92c623b..5723a83 100644 --- a/base/process_util_unittest.cc +++ b/base/process_util_unittest.cc @@ -67,8 +67,7 @@ TEST_F(ProcessUtilTest, KillSlowChild) { EXPECT_EQ(oldcount+1, GetProcessCount(L"base_unittests" EXE_SUFFIX, 0)); FILE *fp = fopen("SlowChildProcess.die", "w"); fclose(fp); - // TODO(port): do something less racy here - PlatformThread::Sleep(1000); + EXPECT_TRUE(base::WaitForSingleProcess(handle, 5000)); EXPECT_EQ(oldcount, GetProcessCount(L"base_unittests" EXE_SUFFIX, 0)); } #endif |