diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-29 20:06:18 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-29 20:06:18 +0000 |
| commit | fdce4788af32cb9af8d77361cfddb96249263437 (patch) | |
| tree | 30c6e4b04a7f46658a57a1265729e0b5ebd2de10 /base/rand_util.h | |
| parent | 7d1025eeb76f1fe0e7bfe19f9f23b64974a63820 (diff) | |
| download | chromium_src-fdce4788af32cb9af8d77361cfddb96249263437.zip chromium_src-fdce4788af32cb9af8d77361cfddb96249263437.tar.gz chromium_src-fdce4788af32cb9af8d77361cfddb96249263437.tar.bz2 | |
ake string_util::WriteInto() DCHECK() that the supplied |length_with_null| > 1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all.
Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8418034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/rand_util.h')
| -rw-r--r-- | base/rand_util.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/base/rand_util.h b/base/rand_util.h index 4474c02..8d795a3 100644 --- a/base/rand_util.h +++ b/base/rand_util.h @@ -38,9 +38,9 @@ BASE_EXPORT double BitsToOpenEndedUnitInterval(uint64 bits); BASE_EXPORT void RandBytes(void* output, size_t output_length); // Fills a string of length |length| with with cryptographically strong random -// data and returns it. +// data and returns it. |length| should be nonzero. // -// Not that this is a variation of |RandBytes| with a different return type. +// Note that this is a variation of |RandBytes| with a different return type. BASE_EXPORT std::string RandBytesAsString(size_t length); } // namespace base |