GTK: Remove OwnedWidgetGtk wrapper for the GtkMenu* in MenuGtk.

The "execute the command later" workaround, which was in place to avoid OwnedWidget-DCHECKing when selecting menu items that might cause cascading object-destruction effects, caused problems with the Browser::SetBlockCommandExecution() workaround, the reasoning for which can be found in BrowserWindowGtk and is reproduced here:

    // This piece of code is based on the fact that calling
    // gtk_window_activate_key() method against |window_| may only trigger a
    // browser command execution, by matching either a global accelerator
    // defined in above |kAcceleratorMap| or the accelerator key of a menu
    // item defined in chrome/browser/gtk/standard_menus.cc.
    //
    // Here we need to retrieve the command id (if any) associated to the
    // keyboard event. Instead of looking up the command id in above
    // |kAcceleratorMap| table by ourselves, we block the command execution of
    // the |browser_| object then send the keyboard event to the |window_| by
    // calling gtk_window_activate_key() method, as if we are activating an
    // accelerator key. Then we can retrieve the command id from the
    // |browser_| object.
    //
    // Pros of this approach:
    // 1. We can handle accelerators defined not only in above
    //    |kAcceleratorMap| table, but also those in standard_menus.cc.
    // 2. We don't need to care about keyboard layout problem, as
    //    gtk_window_activate_key() method handles it for us.
    //
    // Cons:
    // 1. The logic is a little complicated.
    // 2. We should be careful not to introduce any accelerators that trigger
    //    customized code instead of browser commands.

The easiest and cleanest thing is just to remove the OwnedWidgetGtk.

BUG=none
TEST=interactive ui tests pass again

Review URL: http://codereview.chromium.org/522028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35404 0039d316-1c4b-4281-b951-d872f2087c98

0 files changed, 0 insertions, 0 deletions