diff options
author | skerner@chromium.org <skerner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-30 07:19:11 +0000 |
---|---|---|
committer | skerner@chromium.org <skerner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-30 07:19:11 +0000 |
commit | 046062e82159edaeedbbf244731a4d306902d016 (patch) | |
tree | a08e8309b22aa1a45955735dda35ee7c83d2d9de /base/scoped_temp_dir.cc | |
parent | 2082cb3dbf0e611b109909fca14be2e217087970 (diff) | |
download | chromium_src-046062e82159edaeedbbf244731a4d306902d016.zip chromium_src-046062e82159edaeedbbf244731a4d306902d016.tar.gz chromium_src-046062e82159edaeedbbf244731a4d306902d016.tar.bz2 |
Revert 51231 - Loosen permission on extension temp dir when a flag is used.
Issue 35198 can not be reproduced locally. To enable users to do experiments, three command line flags are added to chrome:
--issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped.
--issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process.
--issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory.
BUG=35198
TEST=manual
Review URL: http://codereview.chromium.org/2802018
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/2861039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51238 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/scoped_temp_dir.cc')
-rw-r--r-- | base/scoped_temp_dir.cc | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/base/scoped_temp_dir.cc b/base/scoped_temp_dir.cc index c3fb00a..c8ed9c6 100644 --- a/base/scoped_temp_dir.cc +++ b/base/scoped_temp_dir.cc @@ -4,7 +4,6 @@ #include "base/scoped_temp_dir.h" -#include "base/command_line.h" #include "base/file_util.h" #include "base/logging.h" #include "base/string_util.h" @@ -27,20 +26,16 @@ bool ScopedTempDir::CreateUniqueTempDir() { return true; } -bool ScopedTempDir::CreateUniqueTempDirUnderPath(const FilePath& base_path, - bool loose_permissions) { +bool ScopedTempDir::CreateUniqueTempDirUnderPath(const FilePath& base_path) { // If |path| does not exist, create it. - if (!file_util::CreateDirectory(base_path)) { - LOG(ERROR) << "Failed to create base directory " << base_path.value(); + if (!file_util::CreateDirectory(base_path)) return false; - } - // Create a new, uniquely named directory under |base_path|. + // Create a new, uniquly named directory under |base_path|. if (!file_util::CreateTemporaryDirInDir( base_path, FILE_PATH_LITERAL("scoped_dir_"), - &path_, - loose_permissions)) { + &path_)) { return false; } return true; |