diff options
| author | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-23 04:09:46 +0000 |
|---|---|---|
| committer | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-23 04:09:46 +0000 |
| commit | bd25f1d16e9f9c8f94a6e761719d7239028447c8 (patch) | |
| tree | 94c4ea7e47626540cf863b359dd9d8e58348dd30 /base/shared_memory_posix.cc | |
| parent | a64a12806c27b34f686cf66700da56b812a9c199 (diff) | |
| download | chromium_src-bd25f1d16e9f9c8f94a6e761719d7239028447c8.zip chromium_src-bd25f1d16e9f9c8f94a6e761719d7239028447c8.tar.gz chromium_src-bd25f1d16e9f9c8f94a6e761719d7239028447c8.tar.bz2 | |
Revert 63600 - Thread IO safety: annotate file_util, and block IO thread from doing IO
Reverting because this breaks the ChromiumOS (dbg) builder.
- Mark functions in file_util_posix as requiring permission to perform
disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
have bugs.
BUG=59847,59849,60207,60211
TEST=no dchecks in debug builds
Review URL: http://codereview.chromium.org/3872002
TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/3983005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63630 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/shared_memory_posix.cc')
| -rw-r--r-- | base/shared_memory_posix.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/base/shared_memory_posix.cc b/base/shared_memory_posix.cc index ae814d7..7283cbd 100644 --- a/base/shared_memory_posix.cc +++ b/base/shared_memory_posix.cc @@ -14,7 +14,6 @@ #include "base/logging.h" #include "base/platform_thread.h" #include "base/safe_strerror_posix.h" -#include "base/thread_restrictions.h" #include "base/utf_string_conversions.h" namespace base { @@ -147,11 +146,6 @@ bool SharedMemory::CreateOrOpen(const std::string& name, int posix_flags, uint32 size) { DCHECK(mapped_file_ == -1); - // This function theoretically can block on the disk, but realistically - // the temporary files we create will just go into the buffer cache - // and be deleted before they ever make it out to disk. - base::ThreadRestrictions::ScopedAllowIO allow_io; - file_util::ScopedFILE file_closer; FILE *fp; |