Eliminate all uses of strerror() in code that uses src/base. strerror() is inherently unsafe in multi-threaded apps because it stores the string in a global buffer. It should never be used. If you want to log an error, use PLOG and friends, or if that's too high-level then use safe_strerror().

TEST=built on Linux in 32-bit and 64-bit mode; ran base_unittests in each case; ran Chromium itself in each case; try servers
BUG=none

Review URL: http://codereview.chromium.org/261055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28850 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 3 insertions, 3 deletions

diff --git a/base/shared_memory_posix.cc b/base/shared_memory_posix.cc
index 8828b10..34e7b72 100644
--- a/base/shared_memory_posix.cc
+++ b/base/shared_memory_posix.cc
@@ -13,6 +13,7 @@
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/platform_thread.h"
+#include "base/safe_strerror_posix.h"
 #include "base/string_util.h"
 
 namespace base {
@@ -188,8 +189,7 @@ bool SharedMemory::CreateOrOpen(const std::wstring &name,
 
   if (fp == NULL) {
     if (posix_flags & O_CREAT)
-      LOG(ERROR) << "Creating shared memory in " << path.value() << " failed: "
-                 << strerror(errno);
+      PLOG(ERROR) << "Creating shared memory in " << path.value() << " failed";
     return false;
   }
 
@@ -291,7 +291,7 @@ void SharedMemory::LockOrUnlockCommon(int function) {
                    << " function:" << function
                    << " fd:" << mapped_file_
                    << " errno:" << errno
-                   << " msg:" << strerror(errno);
+                   << " msg:" << safe_strerror(errno);
     }
   }
 }