summaryrefslogtreecommitdiffstats
path: root/base/shared_memory_win.cc
diff options
context:
space:
mode:
authorhclam@chromium.org <hclam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-18 17:46:31 +0000
committerhclam@chromium.org <hclam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-18 17:46:31 +0000
commitb0af04c4b7595afcfcfe847e232bc6ae88101735 (patch)
tree9218ad9ed34635f3387dbbe7aca25a55e851e690 /base/shared_memory_win.cc
parentf4c6499a37788cd2bc2c4781f005ad2c03fd47e7 (diff)
downloadchromium_src-b0af04c4b7595afcfcfe847e232bc6ae88101735.zip
chromium_src-b0af04c4b7595afcfcfe847e232bc6ae88101735.tar.gz
chromium_src-b0af04c4b7595afcfcfe847e232bc6ae88101735.tar.bz2
Fix a memory leak in ResourceDispatcher
When we delete a ResourceLoaderBridge before OnCompletedRequest is received, bad things happen. There's a lot of leaks at the following points: 1. OnMessageReceived ignores the message. 2. RemovePendingRequest removes it's internal deferred_message_queue. But ViewHostMsg_Resource_DataReceived is not POD. We should also close the shared memory handle inside it. Review URL: http://codereview.chromium.org/115396 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16297 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/shared_memory_win.cc')
-rw-r--r--base/shared_memory_win.cc6
1 files changed, 6 insertions, 0 deletions
diff --git a/base/shared_memory_win.cc b/base/shared_memory_win.cc
index 66f8fb6..dd4c73b 100644
--- a/base/shared_memory_win.cc
+++ b/base/shared_memory_win.cc
@@ -55,6 +55,12 @@ SharedMemoryHandle SharedMemory::NULLHandle() {
return NULL;
}
+// static
+void SharedMemory::CloseHandle(const SharedMemoryHandle& handle) {
+ DCHECK(handle != NULL);
+ ::CloseHandle(handle);
+}
+
bool SharedMemory::Create(const std::wstring &name, bool read_only,
bool open_existing, size_t size) {
DCHECK(mapped_file_ == NULL);