diff options
| author | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-13 18:27:40 +0000 |
|---|---|---|
| committer | tschmelcher@chromium.org <tschmelcher@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-13 18:27:40 +0000 |
| commit | 57b765671983005059e8be4523872796b9505428 (patch) | |
| tree | c84b82b586cae2b39ef784f1ee1d58c1431bb140 /base/stats_table.cc | |
| parent | fd8d08436730ef67591de7665da88e995159b773 (diff) | |
| download | chromium_src-57b765671983005059e8be4523872796b9505428.zip chromium_src-57b765671983005059e8be4523872796b9505428.tar.gz chromium_src-57b765671983005059e8be4523872796b9505428.tar.bz2 | |
Eliminate all uses of strerror() in code that uses src/base. strerror() is inherently unsafe in multi-threaded apps because it stores the string in a global buffer. It should never be used. If you want to log an error, use PLOG and friends, or if that's too high-level then use safe_strerror().
TEST=built on Linux in 32-bit and 64-bit mode; ran base_unittests in each case; ran Chromium itself in each case; try servers
BUG=none
Review URL: http://codereview.chromium.org/261055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28850 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/stats_table.cc')
| -rw-r--r-- | base/stats_table.cc | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/base/stats_table.cc b/base/stats_table.cc index 522db5a..2edbb44 100644 --- a/base/stats_table.cc +++ b/base/stats_table.cc @@ -257,14 +257,8 @@ StatsTable::StatsTable(const std::string& name, int max_threads, impl_ = StatsTablePrivate::New(name, table_size, max_threads, max_counters); - // TODO(port): clean up this error reporting. -#if defined(OS_WIN) if (!impl_) - LOG(ERROR) << "StatsTable did not initialize:" << GetLastError(); -#elif defined(OS_POSIX) - if (!impl_) - LOG(ERROR) << "StatsTable did not initialize:" << strerror(errno); -#endif + PLOG(ERROR) << "StatsTable did not initialize"; } StatsTable::~StatsTable() { |