diff options
author | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-29 13:11:36 +0000 |
---|---|---|
committer | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-29 13:11:36 +0000 |
commit | 2423881b28e6944b3f61fe70af6222ef0a75d59e (patch) | |
tree | 312b39ed379bd480db83b143fba419205698aed9 /base/string_util.cc | |
parent | b7b24f6a1512fdfb3b1f292242e62490b5c6b9fd (diff) | |
download | chromium_src-2423881b28e6944b3f61fe70af6222ef0a75d59e.zip chromium_src-2423881b28e6944b3f61fe70af6222ef0a75d59e.tar.gz chromium_src-2423881b28e6944b3f61fe70af6222ef0a75d59e.tar.bz2 |
Move a few functions commonly called with char* to StringPiece.
In some cases this will avoid the implicit char* -> std::string conversion,
object creation, and string copying. One of the biggest benefit is on Windows,
where we can save some conversions in FilePath::AppendASCII.
Review URL: http://codereview.chromium.org/113996
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17182 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/string_util.cc')
-rw-r--r-- | base/string_util.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/string_util.cc b/base/string_util.cc index c666960..1cdbd7b 100644 --- a/base/string_util.cc +++ b/base/string_util.cc @@ -466,7 +466,7 @@ std::string WideToASCII(const std::wstring& wide) { return std::string(wide.begin(), wide.end()); } -std::wstring ASCIIToWide(const std::string& ascii) { +std::wstring ASCIIToWide(const StringPiece& ascii) { DCHECK(IsStringASCII(ascii)); return std::wstring(ascii.begin(), ascii.end()); } @@ -476,7 +476,7 @@ std::string UTF16ToASCII(const string16& utf16) { return std::string(utf16.begin(), utf16.end()); } -string16 ASCIIToUTF16(const std::string& ascii) { +string16 ASCIIToUTF16(const StringPiece& ascii) { DCHECK(IsStringASCII(ascii)); return string16(ascii.begin(), ascii.end()); } @@ -523,7 +523,7 @@ bool IsStringASCII(const string16& str) { } #endif -bool IsStringASCII(const std::string& str) { +bool IsStringASCII(const StringPiece& str) { return DoIsStringASCII(str); } |