diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-31 17:47:09 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-31 17:47:09 +0000 |
commit | f1d8192134f870445ae76be8c16b1566981c9cce (patch) | |
tree | 99a0bc223c4e8a7715479f7c35cd95c8e85a2f98 /base/string_util.h | |
parent | 34877b3b302e3cb456a705b4b45dd72ae6947c79 (diff) | |
download | chromium_src-f1d8192134f870445ae76be8c16b1566981c9cce.zip chromium_src-f1d8192134f870445ae76be8c16b1566981c9cce.tar.gz chromium_src-f1d8192134f870445ae76be8c16b1566981c9cce.tar.bz2 |
Move ASCIIToWide and ASCIIToUTF16 to utf_string_conversions.h. I've found it
weird that UTF8ToWide is in utf_string_conversions, but ASCIIToWide is in
string_util.h. This should help some dependencies since string_util changes
much more frequently than utf_string_conversions and fewer files will now need
string_utils.
Since this requires a lot of changes, this keeps a forward-declaration in
string_util so I can update the entire project incrementally. This change
updates base and net only.
I removed some includes of string_util from header files in net. In particular,
url_request_context which involved creating a new .cc file to implement a
function (already virtual so there's no speed penalty). It turns out a lot of
files were getting string_util from this include, so I had to update a bunch of
random files to now explicitly include string_util.h
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3076013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54456 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/string_util.h')
-rw-r--r-- | base/string_util.h | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/base/string_util.h b/base/string_util.h index 8e3ae83..762779c 100644 --- a/base/string_util.h +++ b/base/string_util.h @@ -227,11 +227,20 @@ bool ContainsOnlyChars(const std::wstring& input, bool ContainsOnlyChars(const string16& input, const string16& characters); bool ContainsOnlyChars(const std::string& input, const std::string& characters); -// These convert between ASCII (7-bit) and Wide/UTF16 strings. +// Converts to 7-bit ASCII by truncating. The result must be known to be ASCII +// beforehand. std::string WideToASCII(const std::wstring& wide); -std::wstring ASCIIToWide(const base::StringPiece& ascii); std::string UTF16ToASCII(const string16& utf16); -string16 ASCIIToUTF16(const base::StringPiece& ascii); + +// Forward-declares for functions in utf_string_conversions.h. They used to +// be here and they were moved. We keep these here so the entire project +// doesn't need to be switched at once. +// TODO(brettw) delete these when everybody includes utf_string_conversions.h +// instead. +std::wstring ASCIIToWide(const char* ascii); +std::wstring ASCIIToWide(const std::string& ascii); +string16 ASCIIToUTF16(const char* ascii); +string16 ASCIIToUTF16(const std::string& ascii); // Converts the given wide string to the corresponding Latin1. This will fail // (return false) if any characters are more than 255. |