summaryrefslogtreecommitdiffstats
path: root/base/string_util.h
diff options
context:
space:
mode:
authordeanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-29 13:11:36 +0000
committerdeanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-29 13:11:36 +0000
commit2423881b28e6944b3f61fe70af6222ef0a75d59e (patch)
tree312b39ed379bd480db83b143fba419205698aed9 /base/string_util.h
parentb7b24f6a1512fdfb3b1f292242e62490b5c6b9fd (diff)
downloadchromium_src-2423881b28e6944b3f61fe70af6222ef0a75d59e.zip
chromium_src-2423881b28e6944b3f61fe70af6222ef0a75d59e.tar.gz
chromium_src-2423881b28e6944b3f61fe70af6222ef0a75d59e.tar.bz2
Move a few functions commonly called with char* to StringPiece.
In some cases this will avoid the implicit char* -> std::string conversion, object creation, and string copying. One of the biggest benefit is on Windows, where we can save some conversions in FilePath::AppendASCII. Review URL: http://codereview.chromium.org/113996 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17182 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/string_util.h')
-rw-r--r--base/string_util.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/base/string_util.h b/base/string_util.h
index f40cc8d..b082078 100644
--- a/base/string_util.h
+++ b/base/string_util.h
@@ -174,9 +174,9 @@ std::wstring CollapseWhitespace(const std::wstring& text,
// These convert between ASCII (7-bit) and Wide/UTF16 strings.
std::string WideToASCII(const std::wstring& wide);
-std::wstring ASCIIToWide(const std::string& ascii);
+std::wstring ASCIIToWide(const StringPiece& ascii);
std::string UTF16ToASCII(const string16& utf16);
-string16 ASCIIToUTF16(const std::string& ascii);
+string16 ASCIIToUTF16(const StringPiece& ascii);
// These convert between UTF-8, -16, and -32 strings. They are potentially slow,
// so avoid unnecessary conversions. The low-level versions return a boolean
@@ -252,7 +252,7 @@ bool IsString8Bit(const std::wstring& str);
bool IsStringUTF8(const std::string& str);
bool IsStringWideUTF8(const std::wstring& str);
bool IsStringASCII(const std::wstring& str);
-bool IsStringASCII(const std::string& str);
+bool IsStringASCII(const StringPiece& str);
bool IsStringASCII(const string16& str);
// ASCII-specific tolower. The standard library's tolower is locale sensitive,