diff options
| author | jschuh@google.com <jschuh@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-26 23:39:58 +0000 |
|---|---|---|
| committer | jschuh@google.com <jschuh@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-26 23:39:58 +0000 |
| commit | bce55e2762118f3dc567afdd3a7af137899f783a (patch) | |
| tree | bc7815b3a881e3e1017534f8864164599942621c /base/string_util_unittest.cc | |
| parent | ef37e08636e4d5e4be1aa4b14a9e2d3d57fc2cfb (diff) | |
| download | chromium_src-bce55e2762118f3dc567afdd3a7af137899f783a.zip chromium_src-bce55e2762118f3dc567afdd3a7af137899f783a.tar.gz chromium_src-bce55e2762118f3dc567afdd3a7af137899f783a.tar.bz2 | |
Make IsStringUTF8 reject (U+FDD0 .. U+FDEF)
Eliminated the old Mozilla implementation and used an ICU-based implementation.
BUG=2759
TEST=base_unittests --gtest_filter=StringUtilTest.IsStringUTF8
Review URL: http://codereview.chromium.org/661205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40178 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/string_util_unittest.cc')
| -rw-r--r-- | base/string_util_unittest.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/base/string_util_unittest.cc b/base/string_util_unittest.cc index c6961fe..d75104c 100644 --- a/base/string_util_unittest.cc +++ b/base/string_util_unittest.cc @@ -225,14 +225,8 @@ TEST(StringUtilTest, IsStringUTF8) { EXPECT_FALSE(IsStringUTF8("\xef\xbf\xbe")); // U+FFFE) EXPECT_FALSE(IsStringUTF8("\xf0\x8f\xbf\xbe")); // U+1FFFE EXPECT_FALSE(IsStringUTF8("\xf3\xbf\xbf\xbf")); // U+10FFFF - - // This should also be false, but currently we pass them through. - // Disable them for now. -#if 0 EXPECT_FALSE(IsStringUTF8("\xef\xb7\x90")); // U+FDD0 EXPECT_FALSE(IsStringUTF8("\xef\xb7\xaf")); // U+FDEF -#endif - // Strings in legacy encodings. We can certainly make up strings // in a legacy encoding that are valid in UTF-8, but in real data, // most of them are invalid as UTF-8. |