diff options
| author | mostynb@opera.com <mostynb@opera.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-01 14:22:16 +0000 |
|---|---|---|
| committer | mostynb@opera.com <mostynb@opera.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-01 14:22:16 +0000 |
| commit | 2482a195c8b4abffef1e90e321f9095d6e87b96b (patch) | |
| tree | 87f248be68a3ec8da5433b7626438588f5112e78 /base/strings/string_number_conversions_unittest.cc | |
| parent | 1e3b5bc0a22f36ddef63a783997bc02d90b57f56 (diff) | |
| download | chromium_src-2482a195c8b4abffef1e90e321f9095d6e87b96b.zip chromium_src-2482a195c8b4abffef1e90e321f9095d6e87b96b.tar.gz chromium_src-2482a195c8b4abffef1e90e321f9095d6e87b96b.tar.bz2 | |
Feeding negative numbers to the HexStringToUInt64 should fail, with output 0 (the closest value in the datatype's range).
Review URL: https://chromiumcodereview.appspot.com/14109020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197614 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/strings/string_number_conversions_unittest.cc')
| -rw-r--r-- | base/strings/string_number_conversions_unittest.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/base/strings/string_number_conversions_unittest.cc b/base/strings/string_number_conversions_unittest.cc index 937bfb8..4d413d7 100644 --- a/base/strings/string_number_conversions_unittest.cc +++ b/base/strings/string_number_conversions_unittest.cc @@ -317,25 +317,25 @@ TEST(StringNumberConversionsTest, HexStringToUInt64) { } cases[] = { {"0", 0, true}, {"42", 66, true}, - {"-42", static_cast<uint64>(-66), true}, + {"-42", 0, false}, {"+42", 66, true}, {"40acd88557b", GG_INT64_C(4444444448123), true}, {"7fffffff", INT_MAX, true}, - {"-80000000", static_cast<uint64>(INT_MIN), true}, + {"-80000000", 0, false}, {"ffffffff", 0xffffffff, true}, {"DeadBeef", 0xdeadbeef, true}, {"0x42", 66, true}, - {"-0x42", static_cast<uint64>(-66), true}, + {"-0x42", 0, false}, {"+0x42", 66, true}, {"0x40acd88557b", GG_INT64_C(4444444448123), true}, {"0x7fffffff", INT_MAX, true}, - {"-0x80000000", static_cast<uint64>(INT_MIN), true}, + {"-0x80000000", 0, false}, {"0xffffffff", 0xffffffff, true}, {"0XDeadBeef", 0xdeadbeef, true}, {"0x7fffffffffffffff", kint64max, true}, - {"-0x8000000000000000", GG_UINT64_C(0x8000000000000000), true}, + {"-0x8000000000000000", 0, false}, {"0x8000000000000000", GG_UINT64_C(0x8000000000000000), true}, - {"-0x8000000000000001", GG_UINT64_C(0x7fffffffffffffff), true}, + {"-0x8000000000000001", 0, false}, {"0xFFFFFFFFFFFFFFFF", kuint64max, true}, {"FFFFFFFFFFFFFFFF", kuint64max, true}, {"0x0000000000000000", 0, true}, |