diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-19 22:10:03 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-19 22:10:03 +0000 |
commit | a22230c4a7362d73f3e2c9be2d7e25d97245f253 (patch) | |
tree | ef378b20341cec29b7367497b920da85df7375e7 /base/synchronization | |
parent | 5b423bd7dd69b4c977fba2c5f828a7563b3bbb62 (diff) | |
download | chromium_src-a22230c4a7362d73f3e2c9be2d7e25d97245f253.zip chromium_src-a22230c4a7362d73f3e2c9be2d7e25d97245f253.tar.gz chromium_src-a22230c4a7362d73f3e2c9be2d7e25d97245f253.tar.bz2 |
Move spin_wait to base/synchronization.
TEST=it compiles
BUG=none
Review URL: https://chromiumcodereview.appspot.com/6049006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122723 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/synchronization')
-rw-r--r-- | base/synchronization/cancellation_flag_unittest.cc | 2 | ||||
-rw-r--r-- | base/synchronization/condition_variable_unittest.cc | 2 | ||||
-rw-r--r-- | base/synchronization/spin_wait.h | 51 |
3 files changed, 53 insertions, 2 deletions
diff --git a/base/synchronization/cancellation_flag_unittest.cc b/base/synchronization/cancellation_flag_unittest.cc index 9a845de..02a31b5 100644 --- a/base/synchronization/cancellation_flag_unittest.cc +++ b/base/synchronization/cancellation_flag_unittest.cc @@ -9,7 +9,7 @@ #include "base/bind.h" #include "base/logging.h" #include "base/message_loop.h" -#include "base/spin_wait.h" +#include "base/synchronization/spin_wait.h" #include "base/time.h" #include "base/threading/thread.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/base/synchronization/condition_variable_unittest.cc b/base/synchronization/condition_variable_unittest.cc index 5cc9063..584df90 100644 --- a/base/synchronization/condition_variable_unittest.cc +++ b/base/synchronization/condition_variable_unittest.cc @@ -10,9 +10,9 @@ #include "base/logging.h" #include "base/memory/scoped_ptr.h" -#include "base/spin_wait.h" #include "base/synchronization/condition_variable.h" #include "base/synchronization/lock.h" +#include "base/synchronization/spin_wait.h" #include "base/threading/platform_thread.h" #include "base/threading/thread_collision_warner.h" #include "base/time.h" diff --git a/base/synchronization/spin_wait.h b/base/synchronization/spin_wait.h new file mode 100644 index 0000000..884d0c4 --- /dev/null +++ b/base/synchronization/spin_wait.h @@ -0,0 +1,51 @@ +// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file provides a macro ONLY for use in testing. +// DO NOT USE IN PRODUCTION CODE. There are much better ways to wait. + +// This code is very helpful in testing multi-threaded code, without depending +// on almost any primitives. This is especially helpful if you are testing +// those primitive multi-threaded constructs. + +// We provide a simple one argument spin wait (for 1 second), and a generic +// spin wait (for longer periods of time). + +#ifndef BASE_SYNCHRONIZATION_SPIN_WAIT_H_ +#define BASE_SYNCHRONIZATION_SPIN_WAIT_H_ +#pragma once + +#include "base/threading/platform_thread.h" +#include "base/time.h" + +// Provide a macro that will wait no longer than 1 second for an asynchronous +// change is the value of an expression. +// A typical use would be: +// +// SPIN_FOR_1_SECOND_OR_UNTIL_TRUE(0 == f(x)); +// +// The expression will be evaluated repeatedly until it is true, or until +// the time (1 second) expires. +// Since tests generally have a 5 second watch dog timer, this spin loop is +// typically used to get the padding needed on a given test platform to assure +// that the test passes, even if load varies, and external events vary. + +#define SPIN_FOR_1_SECOND_OR_UNTIL_TRUE(expression) \ + SPIN_FOR_TIMEDELTA_OR_UNTIL_TRUE(base::TimeDelta::FromSeconds(1), \ + (expression)) + +#define SPIN_FOR_TIMEDELTA_OR_UNTIL_TRUE(delta, expression) do { \ + base::TimeTicks start = base::TimeTicks::Now(); \ + const base::TimeDelta kTimeout = delta; \ + while (!(expression)) { \ + if (kTimeout < base::TimeTicks::Now() - start) { \ + EXPECT_LE((base::TimeTicks::Now() - start).InMilliseconds(), \ + kTimeout.InMilliseconds()) << "Timed out"; \ + break; \ + } \ + base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(50)); \ + } \ + } while (0) + +#endif // BASE_SYNCHRONIZATION_SPIN_WAIT_H_ |