Base: Truncate the timeout of WaitableEvent::TimedWait on Windows.

The timeout has to be adjusted to milliseconds (the resolution of the
underlying call), but it should be truncated instead of extended,
because the documentation clearly states that the function can fail in
less time than the passed-in timeout, and by definition, the timeout
is the maximum time that the caller is willing to block.

BUG=none

Review URL: https://codereview.chromium.org/1040833002

Cr-Commit-Position: refs/heads/master@{#323178}

1 files changed, 4 insertions, 4 deletions

diff --git a/base/synchronization/waitable_event_win.cc b/base/synchronization/waitable_event_win.cc
index 6bec4b4..4db5627 100644
--- a/base/synchronization/waitable_event_win.cc
+++ b/base/synchronization/waitable_event_win.cc
@@ -51,10 +51,10 @@ void WaitableEvent::Wait() {
 bool WaitableEvent::TimedWait(const TimeDelta& max_time) {
   base::ThreadRestrictions::AssertWaitAllowed();
   DCHECK_GE(max_time, TimeDelta());
-  // Be careful here.  TimeDelta has a precision of microseconds, but this API
-  // is in milliseconds.  If there are 5.5ms left, should the delay be 5 or 6?
-  // It should be 6 to avoid returning too early.
-  DWORD timeout = saturated_cast<DWORD>(max_time.InMillisecondsRoundedUp());
+  // Truncate the timeout to milliseconds. The API specifies that this method
+  // can return in less than |max_time| (when returning false), as the argument
+  // is the maximum time that a caller is willing to wait.
+  DWORD timeout = saturated_cast<DWORD>(max_time.InMilliseconds());
 
   DWORD result = WaitForSingleObject(handle_.Get(), timeout);
   switch (result) {