summaryrefslogtreecommitdiffstats
path: root/base/sys_info_chromeos.cc
diff options
context:
space:
mode:
authorrkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-09 21:33:15 +0000
committerrkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-09 21:33:15 +0000
commit1f05c03ee3753c7407de9af65565d2e2b2e8bd2e (patch)
tree300c516fe77a8f9c23a226025c2a354172a558f2 /base/sys_info_chromeos.cc
parent2b20342b3e216a5e8b8280549c74f52b4b727fcf (diff)
downloadchromium_src-1f05c03ee3753c7407de9af65565d2e2b2e8bd2e.zip
chromium_src-1f05c03ee3753c7407de9af65565d2e2b2e8bd2e.tar.gz
chromium_src-1f05c03ee3753c7407de9af65565d2e2b2e8bd2e.tar.bz2
Revert 88545 - Revert 88470 (broke ServiceProcessStateTest.ForceShutdown on CrOS) - Fix for system version unit tests in cros.
Unit test the revert was to fix is still failing after the revert. Also confirmed that the failing test has nothing to do with this CL. BUG=chromium-os:15789 TEST=Ran try servers to make sure the unit test is not failing anymore, plus viewed all the screens and took screenshots. Screen shots of all effected screens are attached to the cros bug TBR=rkc@chromium.org TBR=rkc@chromium.org Review URL: http://codereview.chromium.org/7044086 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/7044097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88595 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/sys_info_chromeos.cc')
-rw-r--r--base/sys_info_chromeos.cc11
1 files changed, 7 insertions, 4 deletions
diff --git a/base/sys_info_chromeos.cc b/base/sys_info_chromeos.cc
index cd17c18..f724f99 100644
--- a/base/sys_info_chromeos.cc
+++ b/base/sys_info_chromeos.cc
@@ -94,17 +94,20 @@ void SysInfo::ParseLsbRelease(const std::string& lsb_release,
size_t length = lsb_release.find_first_of('\n', start_index) - start_index;
std::string version = lsb_release.substr(start_index, length);
StringTokenizer tokenizer(version, ".");
- for (int i = 0; i < 3 && tokenizer.GetNext(); i++) {
- if (0 == i) {
+ // TODO(rkc): Ignore the 0. here; fix this once we move Chrome OS version
+ // numbers from the 0.xx.yyy.zz format to the xx.yyy.zz format.
+ // Refer to http://code.google.com/p/chromium-os/issues/detail?id=15789
+ for (int i = 0; i < 4 && tokenizer.GetNext(); i++) {
+ if (1 == i) {
StringToInt(tokenizer.token_begin(),
tokenizer.token_end(),
major_version);
*minor_version = *bugfix_version = 0;
- } else if (1 == i) {
+ } else if (2 == i) {
StringToInt(tokenizer.token_begin(),
tokenizer.token_end(),
minor_version);
- } else { // 2 == i
+ } else { // 3 == i
StringToInt(tokenizer.token_begin(),
tokenizer.token_end(),
bugfix_version);