diff options
| author | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-13 00:13:00 +0000 |
|---|---|---|
| committer | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-13 00:13:00 +0000 |
| commit | 1f82b3d181c2e5c87670645f1f298532ca813956 (patch) | |
| tree | dad5003d8c7be671d472e56d80aeb20d9eeb97df /base/sys_string_conversions.h | |
| parent | 7f4ad940481637e20452bc763d83717c7aaa72d3 (diff) | |
| download | chromium_src-1f82b3d181c2e5c87670645f1f298532ca813956.zip chromium_src-1f82b3d181c2e5c87670645f1f298532ca813956.tar.gz chromium_src-1f82b3d181c2e5c87670645f1f298532ca813956.tar.bz2 | |
Don't attempt to forward declare StringPiece.
1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.
BUG=87634
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/8820016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114124 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/sys_string_conversions.h')
| -rw-r--r-- | base/sys_string_conversions.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/base/sys_string_conversions.h b/base/sys_string_conversions.h index d2f4d1b..2be248d 100644 --- a/base/sys_string_conversions.h +++ b/base/sys_string_conversions.h @@ -15,6 +15,7 @@ #include "base/base_export.h" #include "base/basictypes.h" #include "base/string16.h" +#include "base/string_piece.h" #if defined(OS_MACOSX) #include <CoreFoundation/CoreFoundation.h> @@ -27,8 +28,6 @@ class NSString; namespace base { -class StringPiece; - // Converts between wide and UTF-8 representations of a string. On error, the // result is system-dependent. BASE_EXPORT std::string SysWideToUTF8(const std::wstring& wide); |