diff options
author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-09 00:59:31 +0000 |
---|---|---|
committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-09 00:59:31 +0000 |
commit | 963a91b1fda682b844b9ece88d2070862f51893f (patch) | |
tree | 1a12f5e9b33fb4147e130b6ba8203e89b3d8df58 /base/test/multiprocess_test.h | |
parent | a958382be2dbbdd153b01473c4f2498cb9beac28 (diff) | |
download | chromium_src-963a91b1fda682b844b9ece88d2070862f51893f.zip chromium_src-963a91b1fda682b844b9ece88d2070862f51893f.tar.gz chromium_src-963a91b1fda682b844b9ece88d2070862f51893f.tar.bz2 |
Get rid of multiprocess_test's debug_on_start arguments.
(It was only ever given a "true" value once, and even that seemed dubious.)
R=phajdan.jr@chromium.org
TBR=darin@chromium.org, jeremy@chromium.org
Review URL: https://codereview.chromium.org/191483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255801 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/test/multiprocess_test.h')
-rw-r--r-- | base/test/multiprocess_test.h | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/base/test/multiprocess_test.h b/base/test/multiprocess_test.h index 4769a00..a47ef74 100644 --- a/base/test/multiprocess_test.h +++ b/base/test/multiprocess_test.h @@ -35,7 +35,7 @@ namespace base { // // Start a child process and run |a_test_func|. // base::ProcessHandle test_child_handle = // base::SpawnMultiProcessTestChild("a_test_func", command_line, -// options, false); +// options); // // // Do stuff involving |test_child_handle| and the child process.... // @@ -61,8 +61,7 @@ namespace base { ProcessHandle SpawnMultiProcessTestChild( const std::string& procname, const CommandLine& command_line, - const LaunchOptions& options, - bool debug_on_start); + const LaunchOptions& options); // Gets the base command line for |SpawnMultiProcessTestChild()|. To this, you // may add any flags needed for your child process. @@ -107,14 +106,13 @@ class MultiProcessTest : public PlatformTest { // } // // Returns the handle to the child, or NULL on failure - ProcessHandle SpawnChild(const std::string& procname, bool debug_on_start); + ProcessHandle SpawnChild(const std::string& procname); // Run a child process using the given launch options. // // Note: On Windows, you probably want to set |options.start_hidden|. ProcessHandle SpawnChildWithOptions(const std::string& procname, - const LaunchOptions& options, - bool debug_on_start); + const LaunchOptions& options); // Set up the command line used to spawn the child process. // Override this to add things to the command line (calling this first in the @@ -123,8 +121,7 @@ class MultiProcessTest : public PlatformTest { // which they then use directly with |LaunchProcess()|. // TODO(viettrungluu): Remove this and add a virtual // |ModifyChildCommandLine()|; make the two divergent uses more sane. - virtual CommandLine MakeCmdLine(const std::string& procname, - bool debug_on_start); + virtual CommandLine MakeCmdLine(const std::string& procname); private: DISALLOW_COPY_AND_ASSIGN(MultiProcessTest); |