summaryrefslogtreecommitdiffstats
path: root/base/test/multiprocess_test.h
diff options
context:
space:
mode:
authorevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-13 18:51:47 +0000
committerevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-13 18:51:47 +0000
commitb5ce736e9dc768a1156dd33a906b3ed4bfbd2276 (patch)
tree596e448d5064142853a64646a78382398f968adc /base/test/multiprocess_test.h
parent96b3760243c36ed846179c18f22b91d4c996fe66 (diff)
downloadchromium_src-b5ce736e9dc768a1156dd33a906b3ed4bfbd2276.zip
chromium_src-b5ce736e9dc768a1156dd33a906b3ed4bfbd2276.tar.gz
chromium_src-b5ce736e9dc768a1156dd33a906b3ed4bfbd2276.tar.bz2
Clean up users of a deprecated base::LaunchApp API.
BUG=88990 Review URL: http://codereview.chromium.org/7346017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92393 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/test/multiprocess_test.h')
-rw-r--r--base/test/multiprocess_test.h16
1 files changed, 7 insertions, 9 deletions
diff --git a/base/test/multiprocess_test.h b/base/test/multiprocess_test.h
index af7a180..bfb9e2a 100644
--- a/base/test/multiprocess_test.h
+++ b/base/test/multiprocess_test.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -58,6 +58,9 @@ class MultiProcessTest : public PlatformTest {
ProcessHandle SpawnChild(const std::string& procname, bool debug_on_start);
#if defined(OS_POSIX)
+ // TODO(evan): see if we can delete this via more refactoring.
+ // SpawnChild() should just take a base::LaunchOptions so that we don't
+ // need multiple versions of it.
ProcessHandle SpawnChild(const std::string& procname,
const file_handle_mapping_vector& fds_to_map,
bool debug_on_start);
@@ -68,17 +71,12 @@ class MultiProcessTest : public PlatformTest {
bool debug_on_start);
private:
-#if defined(OS_WIN)
- ProcessHandle SpawnChildImpl(const std::string& procname,
- bool debug_on_start);
-
-#elif defined(OS_POSIX)
- // TODO(port): with the CommandLine refactoring, this code is very similar
- // to the Windows code. Investigate whether this can be made shorter.
+ // Shared implementation of SpawnChild.
+ // TODO: |fds_to_map| is unused on Windows; see above TODO about
+ // further refactoring.
ProcessHandle SpawnChildImpl(const std::string& procname,
const file_handle_mapping_vector& fds_to_map,
bool debug_on_start);
-#endif
DISALLOW_COPY_AND_ASSIGN(MultiProcessTest);
};