diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-02 17:50:28 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-02 17:50:28 +0000 |
commit | a6d054e0fbebac6ef52c2d1587c2acced87c10f7 (patch) | |
tree | 6721095802945dbe799db4d5cf9efc7b2fe58885 /base/test/test_file_util.h | |
parent | 5cf675990dde125ed599c2b584d3dc5a3ab2fba2 (diff) | |
download | chromium_src-a6d054e0fbebac6ef52c2d1587c2acced87c10f7.zip chromium_src-a6d054e0fbebac6ef52c2d1587c2acced87c10f7.tar.gz chromium_src-a6d054e0fbebac6ef52c2d1587c2acced87c10f7.tar.bz2 |
Delete CopyRecursiveDirNoCache from test_file_util.
This function was used in only one place and that place was wrong.
The implementation was long and complicated on Windows, and long and
complicated and copied verbatim from elsewhere with 3 lines different on Posix.
The place it was used was in the proxy launcher when copying the profile. It's
not clear to me why we wouldn't want the profile files in the filesystem cache
when running tests. Quite the opposite, we want the tests to run as fast as
possible.
The only place this should matter is in the startup tests. And the startup
tests do things to the profile after it gets copied that should page some files
back in! This adds another step to the startup tests to evict the profile files
for cold startup tests only.
BUG=
Review URL: https://codereview.chromium.org/13394003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191854 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/test/test_file_util.h')
-rw-r--r-- | base/test/test_file_util.h | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/base/test/test_file_util.h b/base/test/test_file_util.h index 8d1be1c..c41045e 100644 --- a/base/test/test_file_util.h +++ b/base/test/test_file_util.h @@ -27,15 +27,6 @@ bool DieFileDie(const base::FilePath& file, bool recurse); // to access this file will result in a cold load from the hard drive. bool EvictFileFromSystemCache(const base::FilePath& file); -// Like CopyFileNoCache but recursively copies all files and subdirectories -// in the given input directory to the output directory. Any files in the -// destination that already exist will be overwritten. -// -// Returns true on success. False means there was some error copying, so the -// state of the destination is unknown. -bool CopyRecursiveDirNoCache(const base::FilePath& source_dir, - const base::FilePath& dest_dir); - #if defined(OS_WIN) // Returns true if the volume supports Alternate Data Streams. bool VolumeSupportsADS(const base::FilePath& path); |