diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-29 03:44:44 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-29 03:44:44 +0000 |
commit | badf5cf5f14c65f6c799ef1fec77cde8351339c2 (patch) | |
tree | 83690887c035e4b457f00404f126f95ad1a90c06 /base/test/test_suite.cc | |
parent | 8cc9738eff9c169487e8356947d88640659fc497 (diff) | |
download | chromium_src-badf5cf5f14c65f6c799ef1fec77cde8351339c2.zip chromium_src-badf5cf5f14c65f6c799ef1fec77cde8351339c2.tar.gz chromium_src-badf5cf5f14c65f6c799ef1fec77cde8351339c2.tar.bz2 |
Expose the sandbox related code through the content API. I did a bit of cleanup while I was doing this.
-got rid of SandboxInitWrapper, since I didn't see a need to expose given that we can just expose sandbox::SandboxInterfaceInfo
-got rid of the duplicated code to initialize the broker
-since I made MainFunctionParams only have the sandbox struct on Windows, I also made the mac specific auto release pool behind an ifdef as well. It seemed odd to make something so mac specific compile on all platforms to save some #ifdefs.
BUG=98716
Review URL: http://codereview.chromium.org/8414020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107863 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/test/test_suite.cc')
-rw-r--r-- | base/test/test_suite.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/base/test/test_suite.cc b/base/test/test_suite.cc index 912a6f9..05dfa31 100644 --- a/base/test/test_suite.cc +++ b/base/test/test_suite.cc @@ -13,7 +13,6 @@ #include "base/file_path.h" #include "base/i18n/icu_util.h" #include "base/logging.h" -#include "base/mac/scoped_nsautorelease_pool.h" #include "base/memory/scoped_ptr.h" #include "base/path_service.h" #include "base/process_util.h" @@ -24,6 +23,7 @@ #include "testing/multiprocess_func_list.h" #if defined(OS_MACOSX) +#include "base/mac/scoped_nsautorelease_pool.h" #include "base/test/mock_chrome_application_mac.h" #endif @@ -123,7 +123,9 @@ void TestSuite::CatchMaybeTests() { // Don't add additional code to this method. Instead add it to // Initialize(). See bug 6436. int TestSuite::Run() { +#if defined(OS_MACOSX) base::mac::ScopedNSAutoreleasePool scoped_pool; +#endif Initialize(); std::string client_func = @@ -152,10 +154,12 @@ int TestSuite::Run() { failing_count, failing_count == 1 ? "test" : "tests"); } +#if defined(OS_MACOSX) // This MUST happen before Shutdown() since Shutdown() tears down // objects (such as NotificationService::current()) that Cocoa // objects use to remove themselves as observers. scoped_pool.Recycle(); +#endif Shutdown(); |